Merge lp:~jameinel/bzr/2.3-push-copy-repo-465517 into lp:bzr/2.3
Status: | Merged |
---|---|
Approved by: | John A Meinel |
Approved revision: | no longer in the source branch. |
Merged at revision: | 5631 |
Proposed branch: | lp:~jameinel/bzr/2.3-push-copy-repo-465517 |
Merge into: | lp:bzr/2.3 |
Diff against target: |
109 lines (+61/-1) 4 files modified
bzrlib/controldir.py (+4/-0) bzrlib/tests/blackbox/test_push.py (+16/-0) bzrlib/tests/per_branch/test_push.py (+36/-1) doc/en/release-notes/bzr-2.3.txt (+5/-0) |
To merge this branch: | bzr merge lp:~jameinel/bzr/2.3-push-copy-repo-465517 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Martin Pool | Approve | ||
Review via email: mp+54218@code.launchpad.net |
Commit message
Fix bug #465517, 'bzr push' to a repo w/ no branch should only push the branch ancestry, not all revs in the repo.
Description of the change
This fixes a long-standing bug. If you interrupt a push to a new branch on Launchpad, it can leave a Repository with no Branch. If you then start the push over again, you end up pushing the whole local repository, instead of just the tip revision. (Most noticeable in my repo that mixes plugins with bzr source.)
It doesn't solve the remaining bug, that the final branch isn't stacked like it should be. But I'm not subscribed as "In Progress" to that bug :).
I'm targeting 2.3 because it was easy enough. I thought about backporting, but at 2.3 we switched from having the code in "bzrdir.py" to "controldir.py", and that was a sufficient threshold that I didn't bother going further back.
W00t.
"But I'm not subscribed as "In Progress" to that bug :)" doesn't parse. Do you mean you're working on that bit as well?