Merge lp:~jameinel/bzr/2.3-get-parent-map-faster into lp:bzr/2.3
Status: | Merged |
---|---|
Approved by: | Jelmer Vernooij |
Approved revision: | no longer in the source branch. |
Merged at revision: | 5662 |
Proposed branch: | lp:~jameinel/bzr/2.3-get-parent-map-faster |
Merge into: | lp:bzr/2.3 |
Diff against target: |
27 lines (+6/-1) 2 files modified
bzrlib/smart/repository.py (+1/-1) doc/en/release-notes/bzr-2.3.txt (+5/-0) |
To merge this branch: | bzr merge lp:~jameinel/bzr/2.3-get-parent-map-faster |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jelmer Vernooij (community) | Approve | ||
Review via email: mp+73678@code.launchpad.net |
Commit message
Speed up ``Repository.
Description of the change
This is just a quick drive-by fix that I discovered while playing with Repository.
This is a server-side fix. It just changes one line from:
small_set.
to
small_set = small_set.
The former always has to iterate all of its parameter, while the later can notice that 'small_set' is smaller, and do a [x for x in small if x not in large]
Using the improved client, it drops the time from about 26s down to about 23s. Which is 10-15% of the time spent discovering. Not world changing, but a very easy fix, as well. The time spent without my get_parent_map client fixes is about 158s down to 155s. So still about 3s overall.
Much more of an issue with the new code, though. :)
sent to pqm by email