Merge lp:~jameinel/bzr/2.1.0b4-490600-no-extensions into lp:bzr

Proposed by John A Meinel
Status: Merged
Merged at revision: not available
Proposed branch: lp:~jameinel/bzr/2.1.0b4-490600-no-extensions
Merge into: lp:bzr
Diff against target: 27 lines (+5/-1)
2 files modified
bzrlib/index.py (+3/-1)
bzrlib/util/_bencode_py.py (+2/-0)
To merge this branch: bzr merge lp:~jameinel/bzr/2.1.0b4-490600-no-extensions
Reviewer Review Type Date Requested Status
Vincent Ladeuil Approve
Review via email: mp+15508@code.launchpad.net
To post a comment you must log in.
Revision history for this message
John A Meinel (jameinel) wrote :

This seems to fix the last few test cases that were failing when extensions were not compiled.

Revision history for this message
Martin Pool (mbp) wrote :

Seems plausible, though I'm not deeply into the history of this bug.

Revision history for this message
Vincent Ladeuil (vila) wrote :

Thanks a lot John, I'll merge.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bzrlib/index.py'
2--- bzrlib/index.py 2009-11-07 01:58:11 +0000
3+++ bzrlib/index.py 2009-12-01 20:00:32 +0000
4@@ -205,7 +205,9 @@
5 if reference not in self._nodes:
6 self._check_key(reference)
7 absent_references.append(reference)
8- node_refs.append(as_st(reference_list))
9+ reference_list = as_st([as_st(ref).intern()
10+ for ref in reference_list])
11+ node_refs.append(reference_list)
12 return as_st(node_refs), absent_references
13
14 def add_node(self, key, value, references=()):
15
16=== modified file 'bzrlib/util/_bencode_py.py'
17--- bzrlib/util/_bencode_py.py 2009-10-13 14:36:50 +0000
18+++ bzrlib/util/_bencode_py.py 2009-12-01 20:00:32 +0000
19@@ -154,6 +154,8 @@
20 encode_int(int(x), r)
21 encode_func[BooleanType] = encode_bool
22
23+from bzrlib._static_tuple_py import StaticTuple
24+encode_func[StaticTuple] = encode_list
25 try:
26 from bzrlib._static_tuple_c import StaticTuple
27 except ImportError: