Merge lp:~jameinel/bzr-builddeb/noinfo into lp:bzr-builddeb

Proposed by John A Meinel
Status: Merged
Merged at revision: not available
Proposed branch: lp:~jameinel/bzr-builddeb/noinfo
Merge into: lp:bzr-builddeb
Diff against target: 132 lines (+16/-16)
1 file modified
upstream.py (+16/-16)
To merge this branch: bzr merge lp:~jameinel/bzr-builddeb/noinfo
Reviewer Review Type Date Requested Status
Bzr-builddeb-hackers Pending
Review via email: mp+18617@code.launchpad.net
To post a comment you must log in.
Revision history for this message
John A Meinel (jameinel) wrote :

trace.info was recently deprecated, so this just changes all calls to call trace.note instead.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'upstream.py'
2--- upstream.py 2010-02-01 17:37:17 +0000
3+++ upstream.py 2010-02-04 17:19:14 +0000
4@@ -28,7 +28,7 @@
5
6 from bzrlib.export import export
7 from bzrlib.revisionspec import RevisionSpec
8-from bzrlib.trace import info
9+from bzrlib.trace import note
10
11 from bzrlib.plugins.builddeb.errors import (
12 MissingUpstreamTarball,
13@@ -86,7 +86,7 @@
14 revid = db.revid_of_upstream_version_from_branch(version)
15 if not db.has_pristine_tar_delta(revid):
16 raise PackageVersionNotPresent(package, version, self)
17- info("Using pristine-tar to reconstruct the needed tarball.")
18+ note("Using pristine-tar to reconstruct the needed tarball.")
19 try:
20 db.reconstruct_pristine_tar(revid, package, version, target_filename)
21 except PristineTarError:
22@@ -112,14 +112,14 @@
23 raise PackageVersionNotPresent(package, upstream_version, self)
24
25 sources.Restart()
26- info("Using apt to look for the upstream tarball.")
27+ note("Using apt to look for the upstream tarball.")
28 while sources.Lookup(package):
29 if upstream_version \
30 == Version(sources.Version).upstream_version:
31 if self._run_apt_source(package, sources.Version, target_dir):
32 return
33 break
34- info("apt could not find the needed tarball.")
35+ note("apt could not find the needed tarball.")
36 raise PackageVersionNotPresent(package, upstream_version, self)
37
38 def _get_command(self, package, version_str):
39@@ -160,7 +160,7 @@
40 self.upstream_branch.lock_read()
41 try:
42 revid = self._get_revision_id(version)
43- info("Exporting upstream branch revision %s to create the tarball",
44+ note("Exporting upstream branch revision %s to create the tarball",
45 revid)
46 target_filename = self._tarball_path(package, version, target_dir)
47 tarball_base = "%s-%s" % (package, version)
48@@ -179,16 +179,16 @@
49
50 def _get_orig_source(self, source_dir, desired_tarball_name,
51 target_dir):
52- info("Trying to use get-orig-source to retrieve needed tarball.")
53+ note("Trying to use get-orig-source to retrieve needed tarball.")
54 command = ["make", "-f", "debian/rules", "get-orig-source"]
55 proc = subprocess.Popen(command, cwd=source_dir)
56 ret = proc.wait()
57 if ret != 0:
58- info("Trying to run get-orig-source rule failed")
59+ note("Trying to run get-orig-source rule failed")
60 return False
61 fetched_tarball = os.path.join(source_dir, desired_tarball_name)
62 if not os.path.exists(fetched_tarball):
63- info("get-orig-source did not create %s", desired_tarball_name)
64+ note("get-orig-source did not create %s", desired_tarball_name)
65 return False
66 repack_tarball(fetched_tarball, desired_tarball_name,
67 target_dir=target_dir)
68@@ -216,7 +216,7 @@
69 return
70 finally:
71 shutil.rmtree(tmpdir)
72- info("No debian/rules file to try and use for a get-orig-source rule")
73+ note("No debian/rules file to try and use for a get-orig-source rule")
74 raise PackageVersionNotPresent(package, version, self)
75
76
77@@ -228,14 +228,14 @@
78 self.larstiq = larstiq
79
80 def _uscan(self, package, upstream_version, watch_file, target_dir):
81- info("Using uscan to look for the upstream tarball.")
82+ note("Using uscan to look for the upstream tarball.")
83 r = os.system("uscan --upstream-version %s --force-download --rename "
84 "--package %s --watchfile %s --check-dirname-level 0 "
85 "--download --repack --destdir %s --download-version %s" %
86 (upstream_version, package, watch_file, target_dir,
87 upstream_version))
88 if r != 0:
89- info("uscan could not find the needed tarball.")
90+ note("uscan could not find the needed tarball.")
91 return False
92 return True
93
94@@ -246,7 +246,7 @@
95 watchfile = 'debian/watch'
96 watch_id = self.tree.path2id(watchfile)
97 if watch_id is None:
98- info("No watch file to use to retrieve upstream tarball.")
99+ note("No watch file to use to retrieve upstream tarball.")
100 return None
101 (tmp, tempfilename) = tempfile.mkstemp()
102 try:
103@@ -293,7 +293,7 @@
104 shutil.rmtree(tmpdir)
105
106 def get_specific_version(self, package, version, target_dir):
107- info("Using the current branch without the 'debian' directory "
108+ note("Using the current branch without the 'debian' directory "
109 "to create the tarball")
110 self._split(package, version,
111 self._tarball_path(package, version, target_dir))
112@@ -403,9 +403,9 @@
113 :param target_dir: The directory to place the tarball in.
114 :return: The path to the tarball.
115 """
116- info("Looking for a way to retrieve the upstream tarball")
117+ note("Looking for a way to retrieve the upstream tarball")
118 if self.already_exists_in_target(target_dir):
119- info("Upstream tarball already exists in build directory, "
120+ note("Upstream tarball already exists in build directory, "
121 "using that")
122 return os.path.join(target_dir, self._tarball_name())
123 if not self.already_exists_in_store():
124@@ -417,7 +417,7 @@
125 except PackageVersionNotPresent:
126 raise MissingUpstreamTarball(self._tarball_name())
127 else:
128- info("Using the upstream tarball that is present in "
129+ note("Using the upstream tarball that is present in "
130 "%s" % self.store_dir)
131 assert self.provide_from_store_dir(target_dir)
132 return os.path.join(target_dir, self._tarball_name())

Subscribers

People subscribed via source and target branches