review: approve
On Wed, 2010-02-03 at 20:19 +0000, John A Meinel wrote: > > + elif right_block is None: > + next_block = left_block > + left_block = step(left_blocks) > ...
> + elif left_block.version > right_block.version: > + # left comes first > + next_block = left_block > + left_block = step(left_blocks)
The None and > cases are the same - I think it would be shorter to group them.
elif right_block_is None or left_block.version > right_block.version:
-Rob
« Back to merge proposal
review: approve
On Wed, 2010-02-03 at 20:19 +0000, John A Meinel wrote:
>
> + elif right_block is None:
> + next_block = left_block
> + left_block = step(left_blocks)
> ...
> + elif left_block.version > right_block. version:
> + # left comes first
> + next_block = left_block
> + left_block = step(left_blocks)
The None and > cases are the same - I think it would be shorter to group
them.
elif right_block_is None or left_block.version > right_block. version:
-Rob