Merge lp:~jamalta/launchpad/relatedbugs-118609 into lp:launchpad

[Jamal Fanaian]

Specified 'bugs' as the site for links in the PersonBugsMenu, so that those links will work correctly, even outside the bugs site.

[Jamal Fanaian (jamalta)]

= Summary =

Link in side menu from person's bug pages is not specifying the bugs site. So when a user clicks "List all related bugs", it will go to the person's overview instead of the related bugs list. (Bug #118609).

== Proposed fix ==

Add site='bugs' to related bugs link in PersonBugsMenu.

== Pre-implementation notes ==

EdwinGrubbs suggested the implementation and noted the correct place for the test.

== Implementation notes ==

To maintain consistency, site='bugs' was added as a parameter for all links in PersonBugsMenu.

== Tests ==

% bin/test -vvct xx-person-bugs

== Demo and Q/A ==

From https://launchpad.dev/~cprov/+assignedbugs click "List all related bugs"

[Gavin Panella (allenap)]

This looks great, thanks for doing it!

I have only one comment. The description in the doctest is a little stylistically off. It should read like documentation. Can I suggest an alternative?

  The person bugs page can be accessed without being in the bugs
  site, yet all the menu links point to the bugs site.

There's no need to mention the bug number.

review: Approve

[Jamal Fanaian (jamalta)]

Updated the description for the doctest. Thanks so much!

=== modified file 'lib/lp/registry/stories/person/xx-person-bugs.txt'
--- lib/lp/registry/stories/person/xx-person-bugs.txt 2010-01-27 17:29:28 +0000
+++ lib/lp/registry/stories/person/xx-person-bugs.txt 2010-01-27 17:49:15 +0000
@@ -147,9 +147,8 @@

 === Person bugs menu ===

-The person bugs page can be accessed without being in the bugs site, so
-make sure the person bugs menu is linking to the bugs site correctly
-(https://launchpad.net/bugs/118609).
+The person bugs page can be accessed without being in the bugs
+site, yet all the menu links point to the bugs site.

     >>> anon_browser.open('http://launchpad.dev/~name12/+assignedbugs')
     >>> print anon_browser.getLink('List commented bugs').url

=== modified file 'lib/lp/registry/browser/person.py'
--- lib/lp/registry/browser/person.py	2010-01-11 20:07:17 +0000
+++ lib/lp/registry/browser/person.py	2010-01-27 17:51:27 +0000
@@ -748,36 +748,36 @@
         text = 'List all related bugs'
         summary = ('Lists all bug reports which %s reported, is assigned to, '
                    'or is subscribed to.' % self.context.displayname)
-        return Link('', text, summary=summary)
+        return Link('', text, site='bugs', summary=summary)
 
     def assignedbugs(self):
         text = 'List assigned bugs'
         summary = 'Lists bugs assigned to %s.' % self.context.displayname
-        return Link('+assignedbugs', text, summary=summary)
+        return Link('+assignedbugs', text, site='bugs', summary=summary)
 
     def softwarebugs(self):
         text = 'Show package report'
         summary = (
             'A summary report for packages where %s is a bug supervisor.'
             % self.context.displayname)
-        return Link('+packagebugs', text, summary=summary)
+        return Link('+packagebugs', text, site='bugs', summary=summary)
 
     def reportedbugs(self):
         text = 'List reported bugs'
         summary = 'Lists bugs reported by %s.' % self.context.displayname
-        return Link('+reportedbugs', text, summary=summary)
+        return Link('+reportedbugs', text, site='bugs', summary=summary)
 
     def subscribedbugs(self):
         text = 'List subscribed bugs'
         summary = ('Lists bug reports %s is subscribed to.'
                    % self.context.displayname)
-        return Link('+subscribedbugs', text, summary=summary)
+        return Link('+subscribedbugs', text, site='bugs', summary=summary)
 
     def commentedbugs(self):
         text = 'List commented bugs'
         summary = ('Lists bug reports on which %s has commented.'
                    % self.context.displayname)
-        return Link('+commentedbugs', text, summary=summary)
+        return Link('+commentedbugs', text, site='bugs', summary=summary)
 
 
 class PersonSpecsMenu(NavigationMenu):

=== modified file 'lib/lp/registry/stories/person/xx-person-bugs.txt'
--- lib/lp/registry/stories/person/xx-person-bugs.txt	2009-09-23 13:11:52 +0000
+++ lib/lp/registry/stories/person/xx-person-bugs.txt	2010-01-27 17:51:27 +0000
@@ -144,3 +144,23 @@
         mozilla-firefox (Debian) Low Confirmed
     13 Launchpad CSS and JS is not testible
         Launchpad Undecided New
+
+=== Person bugs menu ===
+
+The person bugs page can be accessed without being in the bugs
+site, yet all the menu links point to the bugs site.
+
+    >>> anon_browser.open('http://launchpad.dev/~name12/+assignedbugs')
+    >>> print anon_browser.getLink('List commented bugs').url
+    http://bugs.launchpad.dev/~name12/+commentedbugs
+    >>> print anon_browser.getLink('List reported bugs').url
+    http://bugs.launchpad.dev/~name12/+reportedbugs
+    >>> print anon_browser.getLink('List subscribed bugs').url
+    http://bugs.launchpad.dev/~name12/+subscribedbugs
+    >>> print anon_browser.getLink('List all related bugs').url
+    http://bugs.launchpad.dev/~name12
+    >>> print anon_browser.getLink('Show package report').url
+    http://bugs.launchpad.dev/~name12/+packagebugs
+    >>> anon_browser.open('http://launchpad.dev/~name12/+commentedbugs')
+    >>> print anon_browser.getLink('List assigned bugs').url
+    http://bugs.launchpad.dev/~name12/+assignedbugs