Merge lp:~jamalta/gwibber/prev-tab into lp:gwibber/1.2

Proposed by Jamal Fanaian
Status: Rejected
Rejected by: Ken VanDine
Proposed branch: lp:~jamalta/gwibber/prev-tab
Merge into: lp:gwibber/1.2
Diff against target: None lines
To merge this branch: bzr merge lp:~jamalta/gwibber/prev-tab
Reviewer Review Type Date Requested Status
Jamal Fanaian (community) Disapprove
gwibber-committers Pending
Review via email: mp+8542@code.launchpad.net
To post a comment you must log in.
Jamal Fanaian (jamalta) wrote :

This branch is no longer valid as gwibber 2.0 doesn't use tabs (not the same way at least).

review: Disapprove

Unmerged revisions

347. By Jamal Fanaian on 2009-07-08

Added keyboard shortcut to switch to previous tab (Ctrl+Shift+Tab)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'gwibber/client.py'
2--- gwibber/client.py 2009-06-21 01:17:53 +0000
3+++ gwibber/client.py 2009-07-08 20:51:14 +0000
4@@ -287,7 +287,12 @@
5 if e.keyval == gtk.keysyms.F5:
6 self.update()
7 return True
8- if e.keyval == gtk.keysyms.Tab and e.state & gtk.gdk.CONTROL_MASK:
9+ if e.keyval == gtk.keysyms.ISO_Left_Tab and e.state & gtk.gdk.CONTROL_MASK:
10+ if self.tabs.get_current_page() == 0:
11+ self.tabs.set_current_page(len(self.tabs) - 1)
12+ else: self.tabs.prev_page()
13+ return True
14+ elif e.keyval == gtk.keysyms.Tab and e.state & gtk.gdk.CONTROL_MASK:
15 if len(self.tabs) == self.tabs.get_current_page() + 1:
16 self.tabs.set_current_page(0)
17 else: self.tabs.next_page()

Subscribers

People subscribed via source and target branches