Merge lp:~jakedahn/django-nova/fb816 into lp:django-nova

Proposed by Jake Dahn
Status: Merged
Approved by: Devin Carlen
Approved revision: 17
Merged at revision: 17
Proposed branch: lp:~jakedahn/django-nova/fb816
Merge into: lp:django-nova
Diff against target: 11 lines (+0/-1)
1 file modified
src/django_nova/templates/django_nova/keypairs/index.html (+0/-1)
To merge this branch: bzr merge lp:~jakedahn/django-nova/fb816
Reviewer Review Type Date Requested Status
Devin Carlen Approve
Review via email:

Description of the change

This branch fixes the error where firefox, and internet explorer were not asking for confirmation when attempting to delete a keypair.

Confirmations should occur after killing the stray console.log.

To post a comment you must log in.
Revision history for this message
Devin Carlen (devcamcar) wrote :

Nice find!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/django_nova/templates/django_nova/keypairs/index.html'
--- src/django_nova/templates/django_nova/keypairs/index.html 2011-01-17 05:55:41 +0000
+++ src/django_nova/templates/django_nova/keypairs/index.html 2011-02-27 11:36:09 +0000
@@ -48,7 +48,6 @@
48 $(function() {48 $(function() {
49 $('.form-key-delete').submit(function() {49 $('.form-key-delete').submit(function() {
50 _key_name = $(this).children(':first').val()50 _key_name = $(this).children(':first').val()
51 console.log(_key_name);
52 $('#spn_delete_key_name').text(_key_name);51 $('#spn_delete_key_name').text(_key_name);
53 $('#dlg_confirm').dialog('open');52 $('#dlg_confirm').dialog('open');
54 return false;53 return false;


People subscribed via source and target branches

to all changes:
to status/vote changes: