Merge lp:~jacobparker1992/elementaryos/croscore-elementary into lp:~elementary-os/elementaryos/default-settings-trusty

Proposed by Jacob Parker
Status: Rejected
Rejected by: Cody Garver
Proposed branch: lp:~jacobparker1992/elementaryos/croscore-elementary
Merge into: lp:~elementary-os/elementaryos/default-settings-trusty
Diff against target: 135 lines (+121/-0)
2 files modified
31-croscore-elementary.conf (+120/-0)
debian/install (+1/-0)
To merge this branch: bzr merge lp:~jacobparker1992/elementaryos/croscore-elementary
Reviewer Review Type Date Requested Status
Cody Garver (community) Disapprove
Review via email: mp+229501@code.launchpad.net

Description of the change

Relying on the addition of the fonts-croscore package, this addition will enable these fonts to be the default replacements for Arial, TNR, and Consolas in Midori.

To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) wrote :

Sorry, I told you wrong about where to put that conf

bzr mv debian/31-croscore-elementary.conf .

review: Needs Fixing
116. By Jacob Parker

Cody wanted it like this.

117. By Jacob Parker

Accidentally missed a Liberation font

Revision history for this message
Danielle Foré (danrabbit) wrote :

Pacifico is great and I would like to add it, but I still don't want to remove Jenna Sue. They don't really look alike.

AFAICT, Playfair doesn't look anything like Limelight, so I don't think that substitution makes sense either.

Add those two back (keep Pacifico and Playfair) and you've got the 'ok' from me

Revision history for this message
Cody Garver (codygarver) wrote :

It was decided this config would instead go in our fonts branch

review: Disapprove

Unmerged revisions

117. By Jacob Parker

Accidentally missed a Liberation font

116. By Jacob Parker

Cody wanted it like this.

115. By Jacob Parker

Added configuration to get fonts-croscore in Midori

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file '31-croscore-elementary.conf'
2--- 31-croscore-elementary.conf 1970-01-01 00:00:00 +0000
3+++ 31-croscore-elementary.conf 2014-08-06 20:33:19 +0000
4@@ -0,0 +1,120 @@
5+<?xml version="1.0"?>
6+<!DOCTYPE fontconfig SYSTEM "fonts.dtd">
7+<fontconfig>
8+
9+ <!-- The sans-serif font should be Tinos -->
10+ <match target="pattern">
11+ <test qual="any" name="family">
12+ <string>serif</string>
13+ </test>
14+ <edit name="family" mode="assign">
15+ <string>Tinos</string>
16+ </edit>
17+ </match>
18+ <match target="pattern">
19+ <test qual="any" name="family">
20+ <string>Times</string>
21+ </test>
22+ <edit name="family" mode="assign">
23+ <string>Tinos</string>
24+ </edit>
25+ </match>
26+ <match target="pattern">
27+ <test qual="any" name="family">
28+ <string>Times New Roman</string>
29+ </test>
30+ <edit name="family" mode="assign">
31+ <string>Tinos</string>
32+ </edit>
33+ </match>
34+
35+ <!-- The sans-serif font should be Arimo -->
36+ <match target="pattern">
37+ <test qual="any" name="family">
38+ <string>sans serif</string>
39+ </test>
40+ <edit name="family" mode="assign">
41+ <string>Arimo</string>
42+ </edit>
43+ </match>
44+ <match target="pattern">
45+ <test qual="any" name="family">
46+ <string>sans</string>
47+ </test>
48+ <edit name="family" mode="assign">
49+ <string>Arimo</string>
50+ </edit>
51+ </match>
52+ <!-- We need to ensure that layout tests that use "Helvetica" don't
53+ fall back to the default serif font -->
54+ <match target="pattern">
55+ <test qual="any" name="family">
56+ <string>Helvetica</string>
57+ </test>
58+ <edit name="family" mode="assign">
59+ <string>Arimo</string>
60+ </edit>
61+ </match>
62+ <match target="pattern">
63+ <test qual="any" name="family">
64+ <string>Arial</string>
65+ </test>
66+ <edit name="family" mode="assign">
67+ <string>Arimo</string>
68+ </edit>
69+ </match>
70+ <match target="pattern">
71+ <test qual="any" name="family">
72+ <string>Lucida Grande</string>
73+ </test>
74+ <edit name="family" mode="assign">
75+ <string>Arimo</string>
76+ </edit>
77+ </match>
78+
79+ <!-- The Monospace font should be Cousine -->
80+ <match target="pattern">
81+ <test qual="any" name="family">
82+ <string>monospace</string>
83+ </test>
84+ <edit name="family" mode="assign">
85+ <string>Cousine</string>
86+ </edit>
87+ </match>
88+ <match target="pattern">
89+ <test qual="any" name="family">
90+ <string>mono</string>
91+ </test>
92+ <edit name="family" mode="assign">
93+ <string>Cousine</string>
94+ </edit>
95+ </match>
96+ <!-- We need to ensure that layout tests that use "Courier", "Courier New",
97+ and "Monaco" (all monospace fonts) don't fall back to the default
98+ serif font -->
99+ <match target="pattern">
100+ <test qual="any" name="family">
101+ <string>Courier</string>
102+ </test>
103+ <edit name="family" mode="assign">
104+ <string>Cousine</string>
105+ </edit>
106+ </match>
107+ <match target="pattern">
108+ <test qual="any" name="family">
109+ <string>Courier New</string>
110+ </test>
111+ <edit name="family" mode="assign">
112+ <string>Cousine</string>
113+ </edit>
114+ </match>
115+ <match target="pattern">
116+ <test qual="any" name="family">
117+ <string>Monaco</string>
118+ </test>
119+ <edit name="family" mode="assign">
120+ <string>Cousine</string>
121+ </edit>
122+ </match>
123+
124+</fontconfig>
125\ No newline at end of file
126
127=== modified file 'debian/install'
128--- debian/install 2012-09-22 10:38:10 +0000
129+++ debian/install 2014-08-06 20:33:19 +0000
130@@ -1,3 +1,4 @@
131 midori/config /etc/xdg/midori/
132 plank/dock1 /etc/skel/.config/plank/
133 settings.ini /etc/gtk-3.0/
134+31-croscore-elementary.conf /etc/fonts/conf.d/
135\ No newline at end of file

Subscribers

People subscribed via source and target branches