Merge lp:~jackweirdy/vidalia/680192 into lp:ubuntu/saucy/vidalia

Proposed by Jack Wearden
Status: Rejected
Rejected by: Adam Conrad
Proposed branch: lp:~jackweirdy/vidalia/680192
Merge into: lp:ubuntu/saucy/vidalia
Diff against target: 13 lines (+3/-0)
1 file modified
debian/apparmor-profile (+3/-0)
To merge this branch: bzr merge lp:~jackweirdy/vidalia/680192
Reviewer Review Type Date Requested Status
Robie Basak Needs Information
Ubuntu branches Pending
Review via email:

Description of the change

Fixes bug by adding
    /usr/sbin/tor Ux,
to the apparmor profile

To post a comment you must log in.
Revision history for this message
Robie Basak (racb) wrote :


Thanks for the merge proposal. This looks good, but we don't currently have a delta against Debian on this package, and it looks likely that this bug would affect Debian too. We can apply your patch straight to Ubuntu and introduce a delta, but this means that we'll need to start merging every upstream release in Debian into Ubuntu to stop it falling behind. Could you please determine if this bug is relevant to Debian, and if so file a bug in Debian against the vidalia package there, attaching your patch? If this bug is fixed promptly in Debian, then we can just sync the Debian fix to Ubuntu without having to introduce a delta. If it takes longer to fix in Debian, then we can introduce a delta in Ubuntu to fix the problem for now, until the Debian bug is fixed. Thanks!

Revision history for this message
Jack Wearden (jackweirdy) wrote :

Will do that now! Thanks for the help!

Revision history for this message
Robie Basak (racb) wrote :

Thanks for submitting the bug to Debian! Based on the feedback on that bug, I'm not sure of the best approach to take here now. I'll comment on the bug itself.

Revision history for this message
Robie Basak (racb) wrote :

It isn't clear what the appropriate action for the Ubuntu package for vidalia is here, so removing this from the sponsorship queue for now.

review: Needs Information

Unmerged revisions

22. By Jack Wearden <email address hidden>

Fixes bug

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/apparmor-profile'
2--- debian/apparmor-profile 2012-07-13 20:20:45 +0000
3+++ debian/apparmor-profile 2013-08-05 19:08:24 +0000
4@@ -13,6 +13,9 @@
5 /{var/,}run/tor/control.authcookie r,
7 /usr/share/icons/*/index.theme k,
8+ #Fixes ubuntu bug
9+ /usr/sbin/tor Ux,
12 # Site-specific additions and overrides. See local/README for details.
13 #include <local/usr.bin.vidalia>


People subscribed via source and target branches

to all changes: