Prometheus SNMP Exporter Charm

Merge ~jacekn/prometheus-snmp-exporter-charm/+git/prometheus-snmp-exporter-charm:master into prometheus-snmp-exporter-charm:master

  1. Git
  2. lp:~jacekn/prometheus-snmp-exporter-charm/+git/prometheus-snmp-exporter-charm
  3. master
  4. Merge into master
Proposed by Jacek Nykis
Status: Merged
Merged at revision: 3975df2555f4e37a311cff362c917b15f95ed3d5
Proposed branch: ~jacekn/prometheus-snmp-exporter-charm/+git/prometheus-snmp-exporter-charm:master
Merge into: prometheus-snmp-exporter-charm:master
Diff against target: 23 lines (+2/-2)
2 files modified
metadata.yaml (+1/-1)
reactive/prometheus-snmp-exporter.py (+1/-1)
Reviewer Review Type Date Requested Status
Jamon Camisso (community) Approve
Review via email: mp+311054@code.launchpad.net

Description of the change

Fix bugs in snmp-exporter relation

To post a comment you must log in.
Revision history for this message
Jamon Camisso (jamon) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/metadata.yaml b/metadata.yaml
2index 0f5f66a..c7906a9 100644
3--- a/metadata.yaml
4+++ b/metadata.yaml
5@@ -8,5 +8,5 @@ tags:
6 - monitoring
7 subordinate: false
8 provides:
9- alertmanager-service:
10+ snmp-exporter:
11 interface: http
12diff --git a/reactive/prometheus-snmp-exporter.py b/reactive/prometheus-snmp-exporter.py
13index 5be68c9..cbfe9bc 100644
14--- a/reactive/prometheus-snmp-exporter.py
15+++ b/reactive/prometheus-snmp-exporter.py
16@@ -81,6 +81,6 @@ def restart_snmp_exporter():
17
18 # Relations
19 @when('snmp-exporter.started')
20-@when('target.available')
21+@when('snmp-exporter.available') # Relation name is "snmp-exporter"
22 def configure_snmp_exporter_relation(target):
23 target.configure(PORT_DEF)

Subscribers

People subscribed via source and target branches