Merge ~jacekn/charm-prometheus-alertmanager:master into ~prometheus-charmers/charm-prometheus-alertmanager:master

Proposed by Jacek Nykis
Status: Merged
Approved by: Jamon Camisso
Approved revision: 12c8bc5182e95724d2aa089af5b44cd554466c96
Merged at revision: a8559e3dc1747ba82a65f4bbc5cd781edcf1edcf
Proposed branch: ~jacekn/charm-prometheus-alertmanager:master
Merge into: ~prometheus-charmers/charm-prometheus-alertmanager:master
Diff against target: 14 lines (+3/-0)
1 file modified
reactive/alertmanager.py (+3/-0)
Reviewer Review Type Date Requested Status
Prometheus Charmers Pending
Review via email: mp+347151@code.launchpad.net

Commit message

Ensure short CLI options are removed from unitdata when long ones are set to avoid duplicates

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision a8559e3dc1747ba82a65f4bbc5cd781edcf1edcf

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/reactive/alertmanager.py b/reactive/alertmanager.py
2index 6cc06c1..2cc266a 100644
3--- a/reactive/alertmanager.py
4+++ b/reactive/alertmanager.py
5@@ -46,6 +46,9 @@ def runtime_args(key=None, value=None, update=True):
6 args = kv.get('runtime_args', {})
7 if key:
8 if update:
9+ # Ensure we wipe old format options
10+ if key.replace('--', '-') in args:
11+ args.pop(key.replace('--', '-'))
12 args.update({key: value})
13 kv.set('runtime_args', args)
14 else:

Subscribers

People subscribed via source and target branches