Juju Charms Collection
squid-reverseproxy package

Code review comment for lp:~jacekn/charms/trusty/squid-reverseproxy/squid-reverseproxy-nrpe-fix

  1. Trusty Tahr (14.04)
  2. squid-reverseproxy-nrpe-fix
  3. Merge into trunk
Revision history for this message
Jacek Nykis (jacekn) wrote :

Hi Tim,

Understood but how does this relate to my change? I have not touched the piece of code that fails. I am almost certain this is pre existing problem and my change is irrelevant here.

If this MP needs to depend on the Makefile fix so be it but I believe it should be separate piece of work.
When I have time I may look at fixing the Makefile but at this point I have different priorities.

review: Needs Resubmitting

« Back to merge proposal