Juju Charms Collection
haproxy package

Code review comment for lp:~jacekn/charms/precise/haproxy/haproxy-stats-socket

  1. Precise Pangolin (12.04)
  2. haproxy-stats-socket
  3. Merge into trunk
Revision history for this message
Marco Ceppi (marcoceppi) wrote :

The unit tests fail for me:

$ make test

http://paste.ubuntu.com/7033134/

Lint fails with the following:

Checking for Python syntax...
/tmp/precise/haproxy/hooks/hooks.py:638:62: E901 SyntaxError: invalid token
/tmp/precise/haproxy/hooks/tests/utils_for_tests.py:13:32: F821 undefined name 'file'
make: *** [lint] Error 1

Once these have been addressed and you're ready for another review make sure to "Request another review" from "charmers" to have it placed back in the queue. Thanks!

review: Needs Fixing
Reply

« Back to merge proposal