Merge ~jacekn/apache2-charm/+git/apache2-charm:master into apache2-charm:master

Proposed by Jacek Nykis
Status: Merged
Approved by: Junien F
Approved revision: 5c97c6f639721380298d6f41458493339ab35647
Merged at revision: e3834fad8020256ee7c9d67c848bc2e671633737
Proposed branch: ~jacekn/apache2-charm/+git/apache2-charm:master
Merge into: apache2-charm:master
Diff against target: 20 lines (+2/-2)
1 file modified
data/logrotate.conf.template (+2/-2)
Reviewer Review Type Date Requested Status
Junien F Approve
Review via email: mp+347883@code.launchpad.net

Commit message

Relax logfile permissions so that subordinates can read them for archiving or shipping to centralised loggin systems. Fixes LP1724056

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Junien F (axino) wrote :

+1

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision e3834fad8020256ee7c9d67c848bc2e671633737

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/data/logrotate.conf.template b/data/logrotate.conf.template
2index 14e2335..55e26bc 100644
3--- a/data/logrotate.conf.template
4+++ b/data/logrotate.conf.template
5@@ -11,13 +11,13 @@
6 delaycompress
7 notifempty
8 {%- if use_rsyslog %}
9- create 640 syslog adm
10+ create 644 syslog adm
11 sharedscripts
12 postrotate
13 reload rsyslog >/dev/null 2>&1 || true
14 endscript
15 {%- else %}
16- create 640 root adm
17+ create 644 root adm
18 sharedscripts
19 postrotate
20 /etc/init.d/apache2 reload > /dev/null

Subscribers

People subscribed via source and target branches

to all changes: