Merge lp:~jaboing/canonical-identity-provider/sso into lp:canonical-identity-provider/release
Proposed by
Julien Funk
Status: | Merged |
---|---|
Approved by: | Ricardo Kirkner |
Approved revision: | no longer in the source branch. |
Merged at revision: | 392 |
Proposed branch: | lp:~jaboing/canonical-identity-provider/sso |
Merge into: | lp:canonical-identity-provider/release |
Diff against target: |
250 lines (+72/-33) 8 files modified
identityprovider/tests/acceptance/devices/add_device.py (+1/-4) identityprovider/tests/acceptance/devices/add_device_google.py (+8/-5) identityprovider/tests/acceptance/devices/add_device_yubikey.py (+7/-5) identityprovider/tests/acceptance/devices/add_two_devices.py (+10/-5) identityprovider/tests/acceptance/devices/delete_device.py (+2/-6) identityprovider/tests/acceptance/devices/rename_device.py (+9/-7) identityprovider/tests/acceptance/shared/devices.py (+11/-1) identityprovider/tests/acceptance/shared/helpers.py (+24/-0) |
To merge this branch: | bzr merge lp:~jaboing/canonical-identity-provider/sso |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ricardo Kirkner (community) | Approve | ||
Review via email: mp+100224@code.launchpad.net |
Commit message
Removed TWOFACTOR flags and updated scripts to work for Dev/Production/
Description of the change
Removed TWOFACTOR flags and updated scripts to work for Dev/Production/
To post a comment you must log in.
A few comments and questions
- why not refactor the if statement into the register_account helper? (the register_account helper would then be 'smart' enough to created the account if needed or log in with the sanctified account if not); this also reduces the changes required
- l.141-142: the double call to delete_device is intentional?
- removing the TWOFACTOR flag will make this run everywhere (dev, staging, prod), so are we sure these tests pass against staging/prod?
- in login_to_ isdqa_account you create the account if it's missing; but I don't see how this new account gets the necessary twofactor bits enabled (unless register_account does this by default). Why can't we always call login_to_ isdqa_account, both on staging/prod and dev, and get rid of the if statement alltogether?