Merge lp:~jaapz-b/switchboard/fix-1082736 into lp:~elementary-pantheon/switchboard/switchboard

Proposed by Jaap Broekhuizen
Status: Merged
Approved by: David Gomes
Approved revision: 351
Merged at revision: 350
Proposed branch: lp:~jaapz-b/switchboard/fix-1082736
Merge into: lp:~elementary-pantheon/switchboard/switchboard
Diff against target: 46 lines (+8/-6)
1 file modified
Switchboard/switchboard-app.vala (+8/-6)
To merge this branch: bzr merge lp:~jaapz-b/switchboard/fix-1082736
Reviewer Review Type Date Requested Status
David Gomes (community) Approve
Review via email: mp+138889@code.launchpad.net
To post a comment you must log in.
lp:~jaapz-b/switchboard/fix-1082736 updated
351. By Jaap Broekhuizen

Code formatting.

Revision history for this message
David Gomes (davidgomes) wrote :

Good job, approved.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Switchboard/switchboard-app.vala'
2--- Switchboard/switchboard-app.vala 2012-11-25 19:32:09 +0000
3+++ Switchboard/switchboard-app.vala 2012-12-09 19:14:18 +0000
4@@ -94,10 +94,14 @@
5
6 // Set up socket
7 socket = new Gtk.Socket ();
8- socket.plug_removed.connect(switch_to_icons);
9 socket.set_hexpand(true);
10 socket.set_vexpand(true);
11
12+ socket.plug_removed.connect (() => {
13+ plug_closed ();
14+ return true;
15+ });
16+
17 // Set up accelerators (hotkeys)
18 var accel_group = new Gtk.AccelGroup ();
19 uint accel_key;
20@@ -242,17 +246,14 @@
21 navigation_button.stock_id = Gtk.Stock.HOME;
22 current_plug["title"] = title;
23 current_plug["executable"] = executable;
24+ switch_to_socket ();
25+ main_window.title = @"$APP_TITLE - $title";
26 }
27 } catch { warning(_("Failed to launch plug: title %s | executable %s"), title, executable); }
28 } else {
29 navigation_button.set_sensitive(true);
30 navigation_button.stock_id = Gtk.Stock.HOME;
31 }
32-
33- if (!@extern) {
34- switch_to_socket ();
35- main_window.title = @"$APP_TITLE - $title";
36- }
37 }
38
39 // Change Switchboard title back to "Switchboard"
40@@ -279,6 +280,7 @@
41 search_box.sensitive = false;
42
43 category_view.hide ();
44+ socket.hide ();
45 loading.show_all ();
46 }
47

Subscribers

People subscribed via source and target branches

to all changes: