Merge lp:~jaapz-b/switchboard/fix-1082448 into lp:~elementary-pantheon/switchboard/switchboard

Proposed by Jaap Broekhuizen
Status: Merged
Approved by: David Gomes
Approved revision: 343
Merged at revision: 343
Proposed branch: lp:~jaapz-b/switchboard/fix-1082448
Merge into: lp:~elementary-pantheon/switchboard/switchboard
Diff against target: 27 lines (+3/-2)
1 file modified
Switchboard/switchboard-app.vala (+3/-2)
To merge this branch: bzr merge lp:~jaapz-b/switchboard/fix-1082448
Reviewer Review Type Date Requested Status
David Gomes (community) Approve
Review via email: mp+136013@code.launchpad.net
To post a comment you must log in.
Revision history for this message
David Gomes (davidgomes) wrote :

I really prefer this.

review: Approve
Revision history for this message
David Gomes (davidgomes) wrote :

Good code too.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Switchboard/switchboard-app.vala'
2--- Switchboard/switchboard-app.vala 2012-11-18 13:28:26 +0000
3+++ Switchboard/switchboard-app.vala 2012-11-24 14:22:21 +0000
4@@ -128,6 +128,7 @@
5 toolbar.set_hexpand (true);
6
7 alert_view = new Granite.Widgets.EmbeddedAlert ();
8+ alert_view.set_vexpand (true);
9 grid.attach (alert_view, 0, 2, 1, 1);
10
11 main_window.add (grid);
12@@ -205,13 +206,13 @@
13
14 public void hide_alert () {
15 alert_view.hide ();
16- category_view.show ();
17+ scrollable_view.show ();
18 }
19
20 public void show_alert (string primary_text, string secondary_text, Gtk.MessageType type) {
21 alert_view.set_alert (primary_text, secondary_text, null, true, type);
22 alert_view.show ();
23- category_view.hide ();
24+ scrollable_view.hide ();
25 }
26
27 public void load_plug (string title, string executable, bool @extern) {

Subscribers

People subscribed via source and target branches

to all changes: