Gala

Merge lp:~jaapz-b/gala/fix-1080972 into lp:gala

  1. fix-1080972
  2. Merge into trunk
Proposed by Jaap Broekhuizen
Status: Rejected
Rejected by: Rico Tzschichholz
Proposed branch: lp:~jaapz-b/gala/fix-1080972
Merge into: lp:gala
Diff against target: 18 lines (+6/-2)
1 file modified
src/Widgets/WindowOverview.vala (+6/-2)
To merge this branch: bzr merge lp:~jaapz-b/gala/fix-1080972
Reviewer Review Type Date Requested Status
Rico Tzschichholz Disapprove
Review via email: mp+136504@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

The problem is a bit more complex.

https://code.launchpad.net/~ricotz/gala/lp1080972

review: Disapprove

Unmerged revisions

265. By Jaap Broekhuizen

Wait a while for the thumbnail to completely close, before closing the WindowOverview.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Widgets/WindowOverview.vala'
2--- src/Widgets/WindowOverview.vala 2012-11-17 13:27:46 +0000
3+++ src/Widgets/WindowOverview.vala 2012-11-27 20:01:16 +0000
4@@ -633,8 +633,12 @@
5 children.remove (removed);
6 calculate_places (children);
7
8- if (get_children ().length () == 0)
9- close (false);
10+ if (get_children ().length () == 0) {
11+ Timeout.add (400, () => {
12+ close (true);
13+ return false;
14+ });
15+ }
16 }
17
18 void selected (Window window)

Subscribers

People subscribed via source and target branches