Merge ~j-rivero/ubuntu/+source/ogre-next/+git/ogre-next-2:ubuntu/devel into ubuntu/+source/ogre-next:ubuntu/devel

Proposed by Jose Luis Rivero
Status: Needs review
Proposed branch: ~j-rivero/ubuntu/+source/ogre-next/+git/ogre-next-2:ubuntu/devel
Merge into: ubuntu/+source/ogre-next:ubuntu/devel
Diff against target: 32 lines (+12/-1)
2 files modified
debian/changelog (+12/-0)
debian/rules (+0/-1)
Reviewer Review Type Date Requested Status
Dan Bungert Pending
git-ubuntu import Pending
Review via email: mp+464934@code.launchpad.net

Commit message

Drop CXXFLAGS to back to use default

ABI is affected by the changed of the CXXFLAGS until the point of
making incompatible the use of OGRE plugins by third party libraries
if the same set of flags is not used. The problem is hard to detect
since the ABI symbols change the offset number. Prefer to leave
the default set of flags.

Description of the change

To post a comment you must log in.
Revision history for this message
Dan Bungert (dbungert) wrote :

Hi Jose,

I came across this MP as it shows on the sponsoring report, but it looks like you can upload it directly, correct? I see no reason blocking normal SRU proceedures, so I suggest that you proceed. I'm claiming the review spot for Sponsors so as to remove this from the report, if that's in error please let me know.

Unmerged commits

89a4cb0... by Jose Luis Rivero

Drop CXXFLAGS to back to use default

ABI is affected by the changed of the CXXFLAGS until the point of
making incompatible the use of OGRE plugins by third party libraries
if the same set of flags is not used. The problem is hard to detect
since the ABI symbols change the offset number. Prefer to leave
the default set of flags.

Signed-off-by: Jose Luis Rivero <email address hidden>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 36f8444..e5783cf 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,15 @@
6+ogre-next (2.3.3+dfsg-0ubuntu3) noble; urgency=medium
7+
8+ * Drop CXXFLAGS to back to use default
9+
10+ ABI is affected by the changed of the CXXFLAGS until the point of
11+ making incompatible the use of OGRE plugins by third party libraries
12+ if the same set of flags is not used. The problem is hard to detect
13+ since the ABI symbols change the offset number. Prefer to leave
14+ the default set of flags.
15+
16+ -- Jose Luis Rivero <jrivero@osrfoundation.org> Wed, 24 Apr 2024 11:54:41 +0200
17+
18 ogre-next (2.3.3+dfsg-0ubuntu2) noble; urgency=medium
19
20 * Include the OGRE-Next Module in the installation.
21diff --git a/debian/rules b/debian/rules
22index 0bd67ca..99ee5c2 100755
23--- a/debian/rules
24+++ b/debian/rules
25@@ -12,7 +12,6 @@ endif
26
27 override_dh_auto_configure:
28 dh_auto_configure -- \
29- -DCMAKE_CXX_FLAGS="$(CXXFLAGS) -DDEBUG=0 -D_DEBUG=0" \
30 -DOGRE_LIB_DIRECTORY="lib/$(DEB_HOST_MULTIARCH)" \
31 -DOGRE_USE_NEW_PROJECT_NAME=ON \
32 -DOGRE_FULL_RPATH:BOOL=FALSE \

Subscribers

People subscribed via source and target branches