Merge lp:~izidor/gtg/performance into lp:~gtg/gtg/old-trunk
Status: | Merged | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Merged at revision: | 1177 | ||||||||||||
Proposed branch: | lp:~izidor/gtg/performance | ||||||||||||
Merge into: | lp:~gtg/gtg/old-trunk | ||||||||||||
Diff against target: |
319 lines (+59/-62) 10 files modified
CHANGELOG (+1/-0) GTG/core/datastore.py (+2/-15) GTG/core/plugins/api.py (+6/-7) GTG/gtk/browser/browser.py (+5/-1) GTG/gtk/browser/treeview_factory.py (+11/-3) GTG/plugins/urgency_color/urgency_color.py (+1/-2) GTG/tools/import_liblarch.py (+11/-5) GTG/tools/synchronized.py (+0/-14) gtg (+4/-1) scripts/debug.sh (+18/-14) |
||||||||||||
To merge this branch: | bzr merge lp:~izidor/gtg/performance | ||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Bertrand Rousseau (community) | Approve | ||
Review via email: mp+104525@code.launchpad.net |
Description of the change
I finally made my proposed performance optimization and hopefully, solve all new bugs I introduced. I did have to make changes to liblarch and there is a merge request as well: https:/
How to test it? Run following commands:
mkdir fast-gtg && cd fast-gtg/
bzr branch lp:~izidor/gtg/performance gtg
git clone --branch=
cd gtg/
./scripts/
./scripts/debug.sh -l
Changes I made:
- added a new parameter -l which makes GTG to prefer a local installation of liblarch in ../liblarch rather than the system installation
- parameter -b works again! Run "time ./scripts/debug.sh -l -b" to test how fast your GTG boot up
- background colors are cached instead of recomputing every time. It makes GTG run smoother.
- quiet boot: GTG window is shown only when all tasks are loaded. By the size of your tasks, GTG would start in few seconds:
150 tasks: 4.6 seconds
My 450+ tasks: 10 seconds
Legendary Bryce set: 21 seconds
(The quiet boot should be okay because applications like Firefox takes some time to start too.)
- several improvement on side of liblarch
After merging this patch, GTG won't be perfectly fast. There is still room for improvement but it would make GTG more useable.
Wow, the performance boost is amazing! It's great to have GTG feeling snappy! Congrats Izidor, you've done a great work there!
The quiet boot option is ok it's WAY better than having the tasks and tags appearing progressively, and still not be able to interact with GTG. I guess we could expect not to have more bryce's task count (I expect most people to have less than 100 tasks - btw, we could make a survey about this sometimes), so it should be allright. If it bothers people, there are ways to help with this (e.g. popup with loading bar, show GTG brower but make the lists inactive, etc.)
For me, your GTG patch is good to go!