Merge lp:~izidor/gtg/bug1018805 into lp:~gtg/gtg/old-trunk

[Izidor Matušov]

Fix for bug #1018805: Crash when entering invalid date

My solution solves the bug. There is also side effect (which was already there before the fix):
 1, Create invalid dates in both fields, e.g "fjasdlfjalsd", "fjasdljfalsd"
 2, Select calendar in start date and choose a date
 3, Start date is updated *and* due date is cleared instead of preserving the invalid date.

Is it acceptable behavior for GTG?

[Bertrand Rousseau (bertrand-rousseau)]

It's ok for me, no need to nitpick for trashing an invalid date.

review: Approve (code)

[Lionel Dricot (ploum-deactivatedaccount)]

review: Approve

=== modified file 'GTG/gtk/editor/editor.py'
--- GTG/gtk/editor/editor.py	2012-05-20 18:14:23 +0000
+++ GTG/gtk/editor/editor.py	2012-06-30 11:58:19 +0000
@@ -265,14 +265,24 @@
 
         #refreshing the start date field
         startdate = self.task.get_start_date()
-        prevdate = Date.parse(self.startdate_widget.get_text())
-        if startdate != prevdate:
+        try:
+            prevdate = Date.parse(self.startdate_widget.get_text())
+            update_date = startdate != prevdate
+        except ValueError:
+            update_date = True
+
+        if update_date:
             self.startdate_widget.set_text(str(startdate)) 
 
         #refreshing the due date field
         duedate = self.task.get_due_date()
-        prevdate = Date.parse(self.duedate_widget.get_text())
-        if duedate != prevdate:
+        try:
+            prevdate = Date.parse(self.duedate_widget.get_text())
+            update_date = duedate != prevdate
+        except ValueError:
+            update_date = True
+
+        if update_date:
             self.duedate_widget.set_text(str(duedate))
 
         # refreshing the closed date field