Merge lp:~iwarford/do-plugins/inline-google-fix into lp:do-plugins

[Ian Warford]

[Ian Warford (iwarford)]

Fixed to merge with the new trunk.

* Fixes bugs in the old Google Search plugin (the preference pane was borked)
* Adds the ability to have it go straight to the google search page
* Adds the option to have it add the google search page as the first result

[Alex Launi (alexlauni)]

for IEnumerable<Type> SupportedItemTypes, instead of returning an array, use the yield keyword.
With the new API you don't need ModifierItemsOptional

I would think about changing the array to an IEnumerable in GoogleSearch.Search

Why was the search action's name changed from "search google" => "google search"? the first makes more sense for an action.

A bunch of calls in perform do not have spaces between the call and the paren. This is also true in the config

review: Needs Fixing

[Ian Warford (iwarford)]

On Wed, Dec 31, 2008 at 11:21 AM, Alex Launi <email address hidden> wrote:
> Review: Needs Fixing
> for IEnumerable<Type> SupportedItemTypes, instead of returning an array, use the yield keyword.
> With the new API you don't need ModifierItemsOptional
>
> I would think about changing the array to an IEnumerable in GoogleSearch.Search
>
> Why was the search action's name changed from "search google" => "google search"? the first makes more sense for an action.

Bug 261295, IIRC. All of the Google-related plugins start with the
world Google *except* the search one. Ordering in the plugins pane
was considered more important than semantics.

> A bunch of calls in perform do not have spaces between the call and the paren. This is also true in the config

I'll see if I get a chance to get the rest of the stuff done tonight.
If not, I have tomorrow off.

[Alex Launi (alexlauni)]

On Wed, Dec 31, 2008 at 11:51 AM, Ian Warford <email address hidden> wrote:

> Bug 261295, IIRC. All of the Google-related plugins start with the
> world Google *except* the search one. Ordering in the plugins pane
> was considered more important than semantics.

Action name and plugin name are not the same. The PLUGIN should be called
Google Search, the ACTION should be Search Google.

--
--Alex Launi

[lp:~iwarford/do-plugins/inline-google-fix]

286. By Ian Warford <iwarford@motoko> on 2009-01-02

Addressed various issues for review. Made some things IEnumerables, and some formatting changes.

287. By Ian Warford <iwarford@motoko> on 2009-01-02

Merged trunk into here.

[Ian Warford (iwarford)]

Addressed everything that I'm aware of. Fixed a bunch of formatting, made some of the strings +
that +
were +
split +
up whole again, and added spaces before ()'s.

Took a while chasing down what appears to be a bug or issue in handling notification events. The upshot is that if you do something that creates a notification -- a google search that returns no results back to Do -- it may randomly hang for as long as 5 minutes (or it may not hang at all).

[lp:~iwarford/do-plugins/inline-google-fix]

288. By Ian Warford <iwarford@motoko> on 2009-01-02

Code review changes. Replaced Console WriteLines with Logs. Other formatting changes.

289. By Ian Warford <iwarford@motoko> on 2009-01-05

Used Invoke() on the Notifications to deal with the locking. Merged trunk into here.