Merge lp:~ivonunes/slingshot/slingshot-focus into lp:~elementary-pantheon/slingshot/trunk

Proposed by Cody Garver
Status: Merged
Merged at revision: 222
Proposed branch: lp:~ivonunes/slingshot/slingshot-focus
Merge into: lp:~elementary-pantheon/slingshot/trunk
Diff against target: 55 lines (+16/-3)
2 files modified
src/Slingshot.vala (+1/-1)
src/SlingshotView.vala (+15/-2)
To merge this branch: bzr merge lp:~ivonunes/slingshot/slingshot-focus
Reviewer Review Type Date Requested Status
Cody Garver (community) Approve
Review via email: mp+111749@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Slingshot.vala'
2--- src/Slingshot.vala 2012-06-21 14:22:15 +0000
3+++ src/Slingshot.vala 2012-06-24 19:02:18 +0000
4@@ -92,7 +92,7 @@
5 }
6 } else {
7 if (view.visible && !silent)
8- view.hide_slingshot ();
9+ view.focus_out ();
10 else
11 view.show_slingshot ();
12 }
13
14=== modified file 'src/SlingshotView.vala'
15--- src/SlingshotView.vala 2012-06-20 22:54:03 +0000
16+++ src/SlingshotView.vala 2012-06-24 19:02:18 +0000
17@@ -224,7 +224,7 @@
18 private void connect_signals () {
19
20 this.focus_out_event.connect (() => {
21- this.hide_slingshot();
22+ this.focus_out();
23 return false;
24 });
25
26@@ -301,7 +301,7 @@
27 switch (Gdk.keyval_name (event.keyval)) {
28
29 case "Escape":
30- hide_slingshot ();
31+ focus_out ();
32 return true;
33
34 case "Return":
35@@ -589,7 +589,20 @@
36 // Show the first page
37 searchbar.text = "";
38
39+ set_opacity (0);
40+
41+ // grab_remove ((Widget) this);
42+ // get_current_event_device ().ungrab (Gdk.CURRENT_TIME);
43+
44+ }
45+
46+ public void focus_out () {
47+
48+ // Show the first page
49+ searchbar.text = "";
50+
51 hide ();
52+ set_opacity (1);
53
54 // grab_remove ((Widget) this);
55 // get_current_event_device ().ungrab (Gdk.CURRENT_TIME);

Subscribers

People subscribed via source and target branches