Merge lp:~ivonunes/pantheon-greeter/deb-packaging-isis-fix into lp:~elementary-os/pantheon-greeter/deb-packaging

[Ivo Nunes]

Fixes setting the default lightdm greeter in Isis, as lightdm-set-defaults no longer exists

Fixes setting the default lightdm greeter in Isis, as lightdm-set-defaults no longer exists.

[Cody Garver (codygarver)]

How did you test this?

[Sergey "Shnatsel" Davidoff (shnatsel)]

lightdm-set-defaults never existed in Ubuntu. Greeter selection was handled by the alternatives system inherited from Debian.

[Sergey "Shnatsel" Davidoff (shnatsel)]

NO NO NO scratch that! It did exist if it's in my maintainer scripts...

But I think it should be handled by alternatives now. Maybe.

[Sergey "Shnatsel" Davidoff (shnatsel)]

Looking at Unity Greeter packaging, this is really the right thing to do. However:
 * The calls to lightdm-set-default should be removed from maintainer scripts, otherwise installation will fail because the binary doesn't exist
 * Add something along the lines of "rm_conffile /etc/lightdm/lightdm.conf.d/40-patheon-greeter.conf" to debian/postrm to avoid declaring the greeter as existing when the package is removed (but not purged)

review: Needs Fixing

[Sergey "Shnatsel" Davidoff (shnatsel)]

Actually scratch that too! The settings were moved to /usr/share so that dpkg won't treat them as config files anymore. So rm_conffile should be no longer needed.

But missing /usr/lib/lightdm/lightdm-set-defaults will be a problem, so ditch calls to it from maintainer scripts.

Sorry for the mess!

review: Needs Fixing

[Ivo Nunes (ivonunes)]

Actually, the scripts check if lightdm-set-defaults exists before calling it, so they don't fail.

This way it keeps compatibility with the older lightdm too.

review: Needs Resubmitting

[Ivo Nunes (ivonunes)]

Ups, I might have put a wrong review flag on my last comment. Ignore it.

[Ivo Nunes (ivonunes)]

review: Abstain

[Sergey "Shnatsel" Davidoff (shnatsel)]

What a poor excuse for a reviewer am I...

review: Approve

=== added file 'debian/40-pantheon-greeter.conf'
--- debian/40-pantheon-greeter.conf	1970-01-01 00:00:00 +0000
+++ debian/40-pantheon-greeter.conf	2014-02-15 12:15:17 +0000
@@ -0,0 +1,2 @@
+[SeatDefaults]
+greeter-session=pantheon-greeter

=== added file 'debian/install'
--- debian/install	1970-01-01 00:00:00 +0000
+++ debian/install	2014-02-15 12:15:17 +0000
@@ -0,0 +1,1 @@
+debian/40-pantheon-greeter.conf /usr/share/lightdm/lightdm.conf.d/