Merge lp:~ivoks/charms/trusty/contrail-configuration/host-private-address into lp:~sdn-charmers/charms/trusty/contrail-configuration/trunk

Proposed by Ante Karamatić
Status: Merged
Merged at revision: 60
Proposed branch: lp:~ivoks/charms/trusty/contrail-configuration/host-private-address
Merge into: lp:~sdn-charmers/charms/trusty/contrail-configuration/trunk
Diff against target: 25 lines (+6/-2)
1 file modified
hooks/contrail_configuration_utils.py (+6/-2)
To merge this branch: bzr merge lp:~ivoks/charms/trusty/contrail-configuration/host-private-address
Reviewer Review Type Date Requested Status
Robert Ayres (community) Approve
Review via email: mp+304938@code.launchpad.net

Description of the change

Kafka, cassandra and zookeeper now support defining network that they should bind to. Those should be used by Contrail services if they are defined.

To post a comment you must log in.
Revision history for this message
Robert Ayres (robert-ayres) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/contrail_configuration_utils.py'
2--- hooks/contrail_configuration_utils.py 2016-07-29 05:22:31 +0000
3+++ hooks/contrail_configuration_utils.py 2016-09-05 15:43:14 +0000
4@@ -127,7 +127,9 @@
5 return 8082
6
7 def cassandra_ctx():
8- servers = [ gethostbyname(relation_get("private-address", unit, rid))
9+ servers = [ (relation_get("host", unit, rid) if
10+ relation_get("host", unit, rid) is not None else
11+ gethostbyname(relation_get("private-address", unit, rid)))
12 + ":" + (rpc_port if rpc_port else port)
13 for rid in relation_ids("cassandra")
14 for unit, rpc_port, port in
15@@ -518,7 +520,9 @@
16 render("vnc_api_lib.ini", "/etc/contrail/vnc_api_lib.ini", ctx)
17
18 def zookeeper_ctx():
19- return { "zk_servers": [ gethostbyname(relation_get("private-address", unit, rid))
20+ return { "zk_servers": [ (relation_get("host", unit, rid) if
21+ relation_get("host", unit, rid) is not None else
22+ gethostbyname(relation_get("private-address", unit, rid)))
23 + ":" + port
24 for rid in relation_ids("zookeeper")
25 for unit, port in

Subscribers

People subscribed via source and target branches