Merge lp:~ivo-kracht/launchpad/bug-1013281 into lp:launchpad

Proposed by Ivo Kracht on 2012-07-02
Status: Merged
Approved by: Curtis Hovey on 2012-07-02
Approved revision: no longer in the source branch.
Merged at revision: 15534
Proposed branch: lp:~ivo-kracht/launchpad/bug-1013281
Merge into: lp:launchpad
Diff against target: 26 lines (+4/-1)
2 files modified
lib/canonical/launchpad/icing/inline-sprites-2.css.in (+3/-0)
lib/lp/bugs/templates/buglisting.mustache (+1/-1)
To merge this branch: bzr merge lp:~ivo-kracht/launchpad/bug-1013281
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code + ui 2012-07-02 Approve on 2012-07-02
Review via email: mp+113062@code.launchpad.net

Commit Message

new icon for bug age in buglistings implemented

Description of the Change

I just added the new icon into the template. There are no tests for this as far as I know. If I missed something, the ec2 test will reveal it.

Pre-imp call with adeuring and sinzui

to test it just open any bug listing with bug age being viewed.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/canonical/launchpad/icing/inline-sprites-2.css.in
  lib/canonical/launchpad/images/aging.png
  lib/lp/bugs/templates/buglisting.mustache

To post a comment you must log in.
Curtis Hovey (sinzui) wrote :

Thank you.

review: Approve (code + ui)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/launchpad/icing/inline-sprites-2.css.in'
2--- lib/canonical/launchpad/icing/inline-sprites-2.css.in 2012-06-02 03:10:14 +0000
3+++ lib/canonical/launchpad/icing/inline-sprites-2.css.in 2012-07-02 15:06:23 +0000
4@@ -29,3 +29,6 @@
5 background-image: url(/@@/zoom-out.png); /* sprite-ref: icon-sprites */
6 background-repeat: no-repeat;
7 }
8+.aging {
9+ background-image: url(/@@/aging.png); /* sprite-ref: icon-sprites */
10+ background-repeat: no-repeat;
11\ No newline at end of file
12
13=== added file 'lib/canonical/launchpad/images/aging.png'
14Binary files lib/canonical/launchpad/images/aging.png 1970-01-01 00:00:00 +0000 and lib/canonical/launchpad/images/aging.png 2012-07-02 15:06:23 +0000 differ
15=== modified file 'lib/lp/bugs/templates/buglisting.mustache'
16--- lib/lp/bugs/templates/buglisting.mustache 2012-01-12 11:28:03 +0000
17+++ lib/lp/bugs/templates/buglisting.mustache 2012-07-02 15:06:23 +0000
18@@ -55,7 +55,7 @@
19 </span>
20 {{/show_reporter}}
21 {{#show_datecreated}}
22- <span class="sprite milestone field">
23+ <span class="sprite aging field">
24 {{age}}
25 </span>
26 {{/show_datecreated}}