Merge lp:~ivenvd/compiz/compiz.fix_1189374 into lp:compiz/0.9.10

Proposed by Iven Hsu
Status: Merged
Approved by: Sam Spilsbury
Approved revision: 3737
Merged at revision: 3737
Proposed branch: lp:~ivenvd/compiz/compiz.fix_1189374
Merge into: lp:compiz/0.9.10
Diff against target: 17 lines (+4/-3)
1 file modified
plugins/opacify/src/opacify.cpp (+4/-3)
To merge this branch: bzr merge lp:~ivenvd/compiz/compiz.fix_1189374
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Sam Spilsbury Approve
MC Return Approve
Review via email: mp+168382@code.launchpad.net

Commit message

Opacify: Only dim the windows above the active window.(LP: #1189374)

To post a comment you must log in.
Revision history for this message
MC Return (mc-return) wrote :

Yes, this is correct.

Thanks for fixing it. +1.
Could you please add a commit message so we can merge this ?

I noticed another bug though:
The "Only increase opacity if a window is blocking" option in CCSM is not even implemented. But it has nothing to do with this fix and the regression I introduced.

review: Approve
Revision history for this message
Sam Spilsbury (smspillaz) :
review: Approve
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

(A word of warning about why code changes without tests are a bad idea).

Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/opacify/src/opacify.cpp'
2--- plugins/opacify/src/opacify.cpp 2013-05-28 08:21:49 +0000
3+++ plugins/opacify/src/opacify.cpp 2013-06-10 08:51:28 +0000
4@@ -156,9 +156,10 @@
5 continue;
6 }
7
8- if (!flag &&
9- !optionGetWindowMatch ().evaluate (w) &&
10- (!w->isViewable () || w->minimized ()))
11+ if (!flag ||
12+ !optionGetWindowMatch ().evaluate (w) ||
13+ !w->isViewable () ||
14+ w->minimized ())
15 continue;
16
17 intersect = w->region ().intersected (fRegion);

Subscribers

People subscribed via source and target branches