Merge ~ivan.hu/plainbox-provider-checkbox:acpi_osi-v3 into plainbox-provider-checkbox:master

Proposed by Ivan Hu
Status: Rejected
Rejected by: Jonathan Cave
Proposed branch: ~ivan.hu/plainbox-provider-checkbox:acpi_osi-v3
Merge into: plainbox-provider-checkbox:master
Diff against target: 54 lines (+30/-0)
4 files modified
bin/acpi_tests.sh (+9/-0)
units/acpi/category.pxu (+8/-0)
units/acpi/jobs.pxu (+8/-0)
units/acpi/test-plan.pxu (+5/-0)
Reviewer Review Type Date Requested Status
Sylvain Pineau Pending
Jonathan Cave Pending
Maciej Kisielewski Pending
Checkbox Developers Pending
Review via email: mp+439799@code.launchpad.net

Commit message

[V3] check that ACPI OEM _OSI strings are present in ACPI BIOS, modify follow merge request 392196,
https://code.launchpad.net/~alexhung/plainbox-provider-checkbox/+git/plainbox-provider-checkbox/+merge/392196

Description of the change

ACPI OEM _OSI strings are used as workaround for NV cards in 2017, and they shouldn't be present in new BIOS code. If they do, it is likely they are used as dirty workarounds.

To post a comment you must log in.
Revision history for this message
Jonathan Cave (jocave) wrote :

Development has moved, please resubmit against the github repo https://github.com/canonical/checkbox the provider is here: https://github.com/canonical/checkbox/tree/main/providers/base

Unmerged commits

ba818af... by Alex Hung

add ACPI OEM _OSI test

OEM _OSI strings were for workarounds in 2016 and 2017. They shouldn't be
used in BIOS/firmware anymore.

Signed-off-by: Alex Hung <email address hidden>
Signed-off-by: Ivan Hu <email address hidden>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/bin/acpi_tests.sh b/bin/acpi_tests.sh
2new file mode 100755
3index 0000000..9713483
4--- /dev/null
5+++ b/bin/acpi_tests.sh
6@@ -0,0 +1,9 @@
7+#!/bin/bash
8+
9+OEM_OSI_LIST=( Linux-Dell-Video Linux-Lenovo-NV-HDMI-Audio Linux-HPI-Hybrid-Graphics )
10+for osi in "${OEM_OSI_LIST[@]}"
11+do
12+ grep -q -r $osi /sys/firmware/acpi/* && exit 1
13+done
14+
15+exit 0
16diff --git a/units/acpi/category.pxu b/units/acpi/category.pxu
17new file mode 100644
18index 0000000..4933cc6
19--- /dev/null
20+++ b/units/acpi/category.pxu
21@@ -0,0 +1,8 @@
22+# Copyright 2020 Canonical Ltd.
23+# All rights reserved.
24+#
25+# Author: Alex Hung<alex.hung@canonical.com>
26+
27+unit: category
28+id: acpi
29+_name: Advanced Configuration and Power Interface
30diff --git a/units/acpi/jobs.pxu b/units/acpi/jobs.pxu
31new file mode 100644
32index 0000000..e0ecc32
33--- /dev/null
34+++ b/units/acpi/jobs.pxu
35@@ -0,0 +1,8 @@
36+id: acpi/oem_osi
37+_summary: test ACPI OEM _OSI strings
38+_description:
39+ This checks if the depreciated OEM _OSI strings are still used by checking the ACPI DSDT and SSDT tables
40+plugin: shell
41+user: root
42+estimated_duration: 1
43+command: acpi_tests.sh
44diff --git a/units/acpi/test-plan.pxu b/units/acpi/test-plan.pxu
45new file mode 100644
46index 0000000..07f8e8c
47--- /dev/null
48+++ b/units/acpi/test-plan.pxu
49@@ -0,0 +1,5 @@
50+id: acpi_oem_osi_strings
51+unit: test plan
52+_name: ACPI OEM _OSI string tests
53+include:
54+ acpi/oem_osi

Subscribers

People subscribed via source and target branches