Merge lp:~ivan-lz/midori/allow_scripts_to_close_windows into lp:midori

Proposed by Cris Dywan
Status: Work in progress
Proposed branch: lp:~ivan-lz/midori/allow_scripts_to_close_windows
Merge into: lp:midori
Diff against target: 18 lines (+8/-0)
1 file modified
midori/midori-preferences.c (+8/-0)
To merge this branch: bzr merge lp:~ivan-lz/midori/allow_scripts_to_close_windows
Reviewer Review Type Date Requested Status
gue5t gue5t Needs Fixing
Review via email: mp+260650@code.launchpad.net

Commit message

Added preference button in Behaviours tab in Prefs

To post a comment you must log in.
Revision history for this message
gue5t gue5t (gue5t) wrote :

The UI looks good and this would be a nice option to have, but there's the setting itself doesn't seem to exist yet.

review: Needs Fixing

Unmerged revisions

6865. By WWW <wlad@vla-laptop>

added preference button in Behaviours tab in Prefs

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'midori/midori-preferences.c'
2--- midori/midori-preferences.c 2014-11-05 21:10:18 +0000
3+++ midori/midori-preferences.c 2015-05-31 00:23:37 +0000
4@@ -393,6 +393,14 @@
5 gtk_button_set_label (GTK_BUTTON (button), _("Allow scripts to open popups"));
6 gtk_widget_set_tooltip_text (button, _("Whether scripts are allowed to open popup windows automatically"));
7 SPANNED_ADD (button);
8+
9+/* new */
10+ button = katze_property_proxy (settings, "javascript-can-close-tabs-automatically", NULL);
11+ gtk_button_set_label (GTK_BUTTON (button), _("Allow scripts to close tabs"));
12+ gtk_widget_set_tooltip_text (button, _("Whether scripts are allowed to close tabs automatically"));
13+ SPANNED_ADD (button);
14+
15+
16 label = gtk_label_new (_("Default Zoom Level"));
17 gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.5);
18 INDENTED_ADD (label);

Subscribers

People subscribed via source and target branches

to all changes: