Merge lp:~ivaldi/midori/tabby-execute-commands into lp:midori

Proposed by André Stösel
Status: Merged
Approved by: Paweł Forysiuk
Approved revision: 6509
Merged at revision: 6517
Proposed branch: lp:~ivaldi/midori/tabby-execute-commands
Merge into: lp:midori
Diff against target: 45 lines (+16/-1)
2 files modified
extensions/tabby.vala (+14/-0)
midori/midori.vapi (+2/-1)
To merge this branch: bzr merge lp:~ivaldi/midori/tabby-execute-commands
Reviewer Review Type Date Requested Status
Paweł Forysiuk Approve
Review via email: mp+197760@code.launchpad.net

Commit message

execute commands given at start time

To post a comment you must log in.
Revision history for this message
André Stösel (ivaldi) wrote :

Right now there is no trivial fix for the event order -> FIXME

Revision history for this message
Paweł Forysiuk (tuxator) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'extensions/tabby.vala'
2--- extensions/tabby.vala 2013-11-19 22:00:40 +0000
3+++ extensions/tabby.vala 2013-12-04 17:39:44 +0000
4@@ -666,6 +666,20 @@
5 this.storage.restore_last_sessions ();
6 }
7
8+ /* FIXME: execute_commands should be called before session creation */
9+ GLib.Idle.add (this.execute_commands);
10+
11+ return false;
12+ }
13+
14+ private bool execute_commands () {
15+ Midori.App app = this.get_app ();
16+ unowned string?[] commands = app.get_data ("execute-commands");
17+
18+ if (commands != null) {
19+ app.send_command (commands);
20+ }
21+
22 return false;
23 }
24
25
26=== modified file 'midori/midori.vapi'
27--- midori/midori.vapi 2013-11-19 19:30:54 +0000
28+++ midori/midori.vapi 2013-12-04 17:39:44 +0000
29@@ -31,6 +31,8 @@
30 public static void set_instance_is_running (bool is_running);
31 public Browser create_browser ();
32 public GLib.List<weak Browser> get_browsers ();
33+ public void send_notification (string title, string message);
34+ public bool send_command ([CCode (array_length = false)] string[] command);
35
36 [NoAccessorMethod]
37 public string name { get; set; }
38@@ -55,7 +57,6 @@
39 public signal void remove_browser (Browser browser);
40 [HasEmitter]
41 public signal void quit ();
42- public void send_notification (string title, string message);
43 }
44
45 [CCode (cheader_filename = "midori/midori.h")]

Subscribers

People subscribed via source and target branches

to all changes: