Midori Web Browser

Merge lp:~ivaldi/midori/katze-set-meta-integer into lp:midori

  1. katze-set-meta-integer
  2. Merge into trunk
Proposed by André Stösel
Status: Merged
Merge reported by: André Stösel
Merged at revision: not available
Proposed branch: lp:~ivaldi/midori/katze-set-meta-integer
Merge into: lp:midori
Diff against target: 11 lines (+2/-0)
1 file modified
katze/katze.vapi (+2/-0)
To merge this branch: bzr merge lp:~ivaldi/midori/katze-set-meta-integer
Reviewer Review Type Date Requested Status
Cris Dywan Needs Fixing
Review via email: mp+186159@code.launchpad.net

Commit message

add set_meta_string and get_meta_string to katze.vapi

To post a comment you must log in.
Revision history for this message
Cris Dywan (kalikiana) wrote :

Obviously correct. Somebody should try to look into auto-generating vapis at some point…

review: Approve
Revision history for this message
Cris Dywan (kalikiana) wrote :

No it's not, sorry. It should be "unowned string" in fact.

review: Needs Fixing
Revision history for this message
André Stösel (ivaldi) wrote :

Hm, yeah, you are right.
(And if I had read this earlier, I would have saved quite some time.)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'katze/katze.vapi'
2--- katze/katze.vapi 2013-04-26 18:04:35 +0000
3+++ katze/katze.vapi 2013-09-22 16:14:15 +0000
4@@ -33,6 +33,8 @@
5 public bool get_meta_boolean (string key);
6 public int64 get_meta_integer (string key);
7 public void set_meta_integer (string key, int64 value);
8+ public unowned string? get_meta_string (string key);
9+ public void set_meta_string (string key, string value);
10 }
11 }
12

Subscribers

People subscribed via source and target branches

to all changes: