Merge lp:~ivaldi/midori/hidden-extension-api into lp:midori

[André Stösel]

bugfix: it should be possible to use exension.set_.. api within hidden extensions

[Cris Dywan (kalikiana)]

Won't this make the extension visible? Which brings us to another problem: if it doesn't, how do you change settings then?

review: Needs Information

[André Stösel (ivaldi)]

No, the extension is still invisible.
And the .set_ - api isn't just for extension settings - it's a easy way to store some information.
(In fact, the api is older than the preferences signal.)

And if the extension is hidden and wants to use this for settings, it can use about:... or something else.

[Cris Dywan (kalikiana)]

I suppose my concerns in terms of UI would really be the same if you used others ways to store settings, what we need longterm is a solid API for the preferences dialog.

review: Approve

=== modified file 'midori/midori-extension.c'
--- midori/midori-extension.c	2013-09-08 00:50:33 +0000
+++ midori/midori-extension.c	2013-09-17 11:27:00 +0000
@@ -674,13 +674,12 @@
     if (katze_array_get_item_index (extensions, extension) >= 0)
         return;
     /* FIXME need proper stock extension mechanism */
-    if (!strcmp (filename, "libtransfers." G_MODULE_SUFFIX)
-     || !strcmp (filename, "libapps." G_MODULE_SUFFIX)
-     || !strcmp (filename, "libdelayed-load." G_MODULE_SUFFIX)
-     || !strcmp (filename, "libtabby." G_MODULE_SUFFIX))
-        return;
+    if (strcmp (filename, "libtransfers." G_MODULE_SUFFIX)
+     && strcmp (filename, "libapps." G_MODULE_SUFFIX)
+     && strcmp (filename, "libdelayed-load." G_MODULE_SUFFIX)
+     && strcmp (filename, "libtabby." G_MODULE_SUFFIX))
+        katze_array_add_item (extensions, extension);
 
-    katze_array_add_item (extensions, extension);
     g_object_unref (extensions);
 
     if (midori_paths_is_readonly ())