Midori Web Browser

Merge lp:~ivaldi/midori/browser-delete-event into lp:midori

  1. browser-delete-event
  2. Merge into trunk
Proposed by André Stösel
Status: Merged
Approved by: Cris Dywan
Approved revision: 6395
Merged at revision: 6399
Proposed branch: lp:~ivaldi/midori/browser-delete-event
Merge into: lp:midori
Diff against target: 18 lines (+7/-1)
1 file modified
midori/midori-browser.c (+7/-1)
To merge this branch: bzr merge lp:~ivaldi/midori/browser-delete-event
Reviewer Review Type Date Requested Status
Cris Dywan Approve
Review via email: mp+185021@code.launchpad.net

Commit message

ctrl+shift+w should trigger a delete-event

To post a comment you must log in.
Revision history for this message
André Stösel (ivaldi) wrote :

This is relevant if a download is running (transfers extension) and for tabby.

Revision history for this message
Cris Dywan (kalikiana) wrote :

This makes perfect sense.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'midori/midori-browser.c'
2--- midori/midori-browser.c 2013-09-08 17:20:49 +0000
3+++ midori/midori-browser.c 2013-09-11 11:34:11 +0000
4@@ -2816,7 +2816,13 @@
5 _action_window_close_activate (GtkAction* action,
6 MidoriBrowser* browser)
7 {
8- gtk_widget_destroy (GTK_WIDGET (browser));
9+ gboolean val = FALSE;
10+ GdkEvent* event = gtk_get_current_event();
11+ g_signal_emit_by_name (G_OBJECT (browser), "delete-event", event, &val);
12+ gdk_event_free (event);
13+
14+ if (!val)
15+ gtk_widget_destroy (GTK_WIDGET (browser));
16 }
17
18 static void

Subscribers

People subscribed via source and target branches

to all changes: