Merge lp:~ivaldi/midori/apps into lp:~kalikiana/midori/apps

Proposed by André Stösel
Status: Merged
Approved by: Cris Dywan
Approved revision: 6179
Merged at revision: 6179
Proposed branch: lp:~ivaldi/midori/apps
Merge into: lp:~kalikiana/midori/apps
Diff against target: 12 lines (+1/-1)
1 file modified
extensions/apps.vala (+1/-1)
To merge this branch: bzr merge lp:~ivaldi/midori/apps
Reviewer Review Type Date Requested Status
Cris Dywan Approve
Review via email: mp+165684@code.launchpad.net

Description of the change

remove leading and trailing whitespace from the .desktop file name

To post a comment you must log in.
Revision history for this message
Cris Dywan (kalikiana) wrote :

Makes sense.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'extensions/apps.vala'
2--- extensions/apps.vala 2013-05-23 22:03:52 +0000
3+++ extensions/apps.vala 2013-05-24 18:59:29 +0000
4@@ -22,7 +22,7 @@
5
6 internal static async void create (string prefix, GLib.File folder, string uri, string title) {
7 /* Strip LRE leading character and / */
8- string filename = title.delimit ("‪/", ' ') + ".desktop";
9+ string filename = title.delimit ("‪/", ' ').strip() + ".desktop";
10 string exec = prefix + uri;
11 string name = title;
12 // TODO: Midori.Paths.get_icon save to png

Subscribers

People subscribed via source and target branches

to all changes: