Merge lp:~itnet7/loco-team-portal/loco-team-portal-lp1100041 into lp:loco-team-portal

Proposed by Chris Crisafulli
Status: Rejected
Rejected by: Adnane Belmadiaf
Proposed branch: lp:~itnet7/loco-team-portal/loco-team-portal-lp1100041
Merge into: lp:loco-team-portal
Diff against target: 18 lines (+3/-3)
1 file modified
loco_directory/teams/models.py (+3/-3)
To merge this branch: bzr merge lp:~itnet7/loco-team-portal/loco-team-portal-lp1100041
Reviewer Review Type Date Requested Status
Adnane Belmadiaf Pending
Review via email: mp+149351@code.launchpad.net

Description of the change

This changes the default character limit from 20 to 30 for Flickr, Picasa, and Pix.ie. It takes care of Bug #1100041: Picasa User ID doesn’t fit into the field. I couldn't get the current development environment up to run to validate the fix, but it seems like it would accomplish the goal.

To post a comment you must log in.
Revision history for this message
Adnane Belmadiaf (daker) wrote :

Hi Chris, thanks for your work, changing the db model needs a south migration script, i have pushed a fix for it https://code.launchpad.net/~daker/loco-team-portal/fix.1100041/+merge/149425

Revision history for this message
Chris Crisafulli (itnet7) wrote :

 Thanks Adnane, I should have known it wasn't that easy. I would like to
try and help you more, I just can't seem to get a local instance running
properly. Any tips or tricks? I was following Liz's
documentation<http://princessleia.com/journal/?p=6662>but it seems
deprecated. After the vagrant server completion, it is seeming
as if the postinstall.sh file doesn't run. I run it manually after ssh'ing
using sudo, and it seems to complete without errors. I then continue on to
try run ./manage.py syncdb, migrate, and runserver, but receive errors
after that. The install file mentions installing and older version of
postgresql, is that one of the steps I'm missing? Thanks for your time and
any help!

Chris

On 02/19/2013 05:40 PM, Adnane Belmadiaf wrote:

Hi Chris, thanks for your work, changing the db model needs a south
migration script, i have pushed a fix for it
https://code.launchpad.net/~daker/loco-team-portal/fix.1100041/+merge/149425

Unmerged revisions

611. By Chris Crisafulli

Changes the max_length for Flickr, Picasa, and Pix.ie

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'loco_directory/teams/models.py'
2--- loco_directory/teams/models.py 2013-02-16 18:50:41 +0000
3+++ loco_directory/teams/models.py 2013-02-19 17:36:47 +0000
4@@ -114,11 +114,11 @@
5 contact_profiles = models.ManyToManyField(UserProfile, related_name='contacts')
6 mugshot_url = models.URLField(_("Team Logo"), verify_exists=False, null=True, blank=True)
7 languages = models.ManyToManyField(Language)
8- flickr_id = models.CharField(_("Flickr User/Group ID"), max_length=20, null=True, blank=True,
9+ flickr_id = models.CharField(_("Flickr User/Group ID"), max_length=30, null=True, blank=True,
10 help_text=_("To get your Flickr user id go to http://idgettr.com. Ex. 47353004@N03"))
11- picasa_id = models.CharField(_("Picasa User ID"), max_length=20, null=True, blank=True,
12+ picasa_id = models.CharField(_("Picasa User ID"), max_length=30, null=True, blank=True,
13 help_text=_("Ex. toto@gmail.com, so your Picasa id is : toto"))
14- pixie_id = models.CharField(_("Pix.ie User ID"), max_length=20, null=True, blank=True,
15+ pixie_id = models.CharField(_("Pix.ie User ID"), max_length=30, null=True, blank=True,
16 help_text=_("Your Pix.ie Username"))
17 microbloghashtag = models.CharField(max_length=50, help_text=_('Hash Tag used for microbloggers to mention this team'), verbose_name=_('Microblogging Hash Tag'), null=True, blank=True)
18 active = models.BooleanField(_("Active Team"), default=True)

Subscribers

People subscribed via source and target branches