lp:~itachi-san/telegram-desktop/gyp

Created by Giovanni Santini on 2016-12-19 and last modified on 2018-12-10
Get this branch:
bzr branch lp:~itachi-san/telegram-desktop/gyp

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Giovanni Santini
Project:
Telegram Desktop
Status:
Development

Import details

Import Status: Reviewed

This branch is an import of the HEAD branch of the Git repository at https://chromium.googlesource.com/external/gyp.

The next import is scheduled to run in 2 hours.

Last successful import was 3 hours ago.

Import started 3 hours ago on alnitak and finished 3 hours ago taking 20 seconds — see the log
Import started 9 hours ago on alnitak and finished 9 hours ago taking 15 seconds — see the log
Import started 15 hours ago on alnitak and finished 15 hours ago taking 15 seconds — see the log
Import started 21 hours ago on alnitak and finished 21 hours ago taking 20 seconds — see the log
Import started on 2018-12-09 on izar and finished on 2018-12-09 taking 20 seconds — see the log
Import started on 2018-12-09 on alnitak and finished on 2018-12-09 taking 20 seconds — see the log
Import started on 2018-12-09 on alnitak and finished on 2018-12-09 taking 15 seconds — see the log
Import started on 2018-12-09 on izar and finished on 2018-12-09 taking 15 seconds — see the log
Import started on 2018-12-08 on alnitak and finished on 2018-12-08 taking 15 seconds — see the log
Import started on 2018-12-08 on izar and finished on 2018-12-08 taking 15 seconds — see the log

Recent revisions

2150. By Refael 3 hours ago

src,win: add VS2019 version

PR-URL: https://github.com/refack/GYP/pull/13
Change-Id: Idcdd59570195efb06285d5114328d74bd8f6d732
Reviewed-on: https://chromium-review.googlesource.com/c/1369264
Reviewed-by: Mark Mentovai <email address hidden>

2149. By Dirk Pranke <email address hidden> on 2018-12-08

Fixes needed for Python3 on Win32.

This CL contains the remaining fixes needed for the tests to
pass when running under Python 3.7 on Win10. Mostly these
are just changes to convert the output of subprocesses to
strings, but there are a few other minor compatibility fixes
as well.

With this CL, Python 3 should work everywhere we support it.
Python 2 continues to work as well.

Bug: gyp:36
Change-Id: Ie696a1845fb2dba4d86929be886becc5d300ef7a
Reviewed-on: https://chromium-review.googlesource.com/c/1365010
Reviewed-by: Mark Mentovai <email address hidden>

2148. By Dirk Pranke <email address hidden> on 2018-12-04

Fix one dangling utf8 decode call needed for python 3.

With this change, the tests should run fine on Python3 on Macs.
Python2 should work fine as well :).

Bug: gyp:36
Change-Id: I044746d44143b2e461feb4e5685d8bef3d6bbd19
Reviewed-on: https://chromium-review.googlesource.com/c/1361812
Reviewed-by: Mark Mentovai <email address hidden>

2147. By Dirk Pranke <email address hidden> on 2018-12-04

Mostly mechanical changes for Python3 support.

Everything should still work fine in Python 2. With this change (and
the others I've just landed), Python 3 should work on at least
Linux, but I need to do more sanity-checking on Mac and Win.

The changes in this CL are all mechanical -- things like
print() instead of print, `key in dict` rather than dict.has_key(key),
and switching to use .decode('utf8') to handle the binary streams
returned from a subprocess (and a few other things).

Most of this work is derived from <email address hidden>'s
original work in https://codereview.chromium.org/1454433002/.

Bug: gyp:36

Change-Id: Ie04ebcf2d82e7b8ff34c6a112215eac46af688ba
Reviewed-on: https://chromium-review.googlesource.com/c/1357805
Reviewed-by: Mark Mentovai <email address hidden>

2146. By Dirk Pranke <email address hidden> on 2018-12-04

Update simple_copy.py for Python3 types.

Python 3 gets rid of 'str', 'long', so the file needed to be
tweaked slightly.

Bug: gyp:36
Change-Id: I7c820dfd6dfb5bfcf1a8ed315d67095557822757
Reviewed-on: https://chromium-review.googlesource.com/c/1360353
Reviewed-by: Mark Mentovai <email address hidden>

2145. By Dirk Pranke <email address hidden> on 2018-12-04

Use ast module instead of compiler module for parsing files.

This CL is part of the work getting GYP to run under Python 3.
The compiler module we used to parse GYP files was removed in
Python 3, so this CL switches to use the ast module instead,
which exists in both Python 2 and Python 3.

This change is not sufficient to run under Python 3; there's
more work remaining. Things should still work under Python 2
just fine.

This work is derived from <email address hidden>'s
original work in https://codereview.chromium.org/1454433002/.

Bug: gyp:36

Change-Id: I9a9835560491c3d8cd5426623484dc4a46af1d86
Reviewed-on: https://chromium-review.googlesource.com/c/1360352
Reviewed-by: Mark Mentovai <email address hidden>

2144. By Dirk Pranke <email address hidden> on 2018-12-04

Make Visual Studio 2017 Community Edition work w/ GYP.

Change-Id: I474dcb1c5f6dea03a5b82af62f90b28e9b9cfbb9
Reviewed-on: https://chromium-review.googlesource.com/c/1358041
Reviewed-by: Mark Mentovai <email address hidden>

2143. By Dirk Pranke <email address hidden> on 2018-12-03

Add a copyright header to TestCmd.py.

Change-Id: I57a59b8b920c7dc9eb46790b00306a04adba35d3
Reviewed-on: https://chromium-review.googlesource.com/c/1357804
Reviewed-by: Mark Mentovai <email address hidden>

2142. By Konstantinov Maxim <email address hidden> on 2018-11-13

Fix issue with missing resources in Xcode ui tests targets.

Adding any entries in 'mac_bundle_resources' section for 'mac_xcuitest_bundle' targets didn't affect generated project.
This change fixes it.

Change-Id: I6d0bbf18deb5a9ffaeb5697f5bae8d72d976b0a1
Reviewed-on: https://chromium-review.googlesource.com/c/1329753
Reviewed-by: Mark Mentovai <email address hidden>

2141. By Dirk Pranke <email address hidden> on 2018-11-07

Patch GYP so that building with Xcode 10 works.

Specifically, this change makes it so that rules explicitly list
 their outputs in the generated Xcode project.

Previously, rules added to Xcode did not list their outputs and this
worked fine because make handled everything correctly. However due to
recent build system improvements made by Apple
(https://developer.apple.com/documentation/xcode_release_notes/xcode_10_release_notes/build_system_release_notes_for_xcode_10?language=objc)
only files explicitly listed as outputs can be referenced in build
targets.

"If an output file which is generated by a shell script is used as an
input elsewhere in the build (for example, to another shell script),
then that output must be declared as an explicit output by the script
that generates it; otherwise the build system may attempt to search for
the file before it has been generated, causing the build to fail."

Change-Id: Ia5c9e8ef604e4268755f11a33ccd2ea9564fd0fe
Reviewed-on: https://chromium-review.googlesource.com/c/1318929
Commit-Queue: Dirk Pranke <email address hidden>
Reviewed-by: Mark Mentovai <email address hidden>

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.

Subscribers

No subscribers.