lp:~itachi-san/telegram-desktop/gyp

Created by Giovanni Santini and last modified
Get this branch:
bzr branch lp:~itachi-san/telegram-desktop/gyp

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Giovanni Santini
Project:
Telegram Desktop
Status:
Development

Import details

Import Status: Reviewed

This branch is an import of the HEAD branch of the Git repository at https://chromium.googlesource.com/external/gyp.

The next import is scheduled to run .

Last successful import was .

Import started on juju-98ee42-prod-launchpad-codeimport-0 and finished taking 10 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-0 and finished taking 15 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-5 and finished taking 15 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-0 and finished taking 10 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-5 and finished taking 10 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-1 and finished taking 5 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-5 and finished taking 10 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-5 and finished taking 10 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-1 and finished taking 10 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-5 and finished taking 10 seconds — see the log

Updating branch...

Launchpad is processing new changes to this branch which will be available in a few minutes. Reload to see the changes.

Recent revisions

2172. By David Gatwood <email address hidden>

Added support for constructing Xcode project files that import XCFrameworks.

Bug: N/A
Change-Id: I7457406894f76110b834fe052d395be2c21ca39a
Reviewed-on: https://chromium-review.googlesource.com/c/external/gyp/+/4858505
Reviewed-by: Mark Mentovai <email address hidden>

2171. By Raymond Zhao <email address hidden>

Add SpectreMitigation attribute for msvs

This CL allows gyp to recognize the SpectreMitigation msvs_attribute
and add it to the generated vcxproj file for MSBuild.
Possible values for the attribute are Spectre, SpectreLoad,
SpectreLoadCF, and false.

The /Qspectre compiler option is not enough to add
full Spectre mitigation, because even though it causes MSBuild
to add additional instructions to the generated object files,
it does not cause MSBuild to link against Spectre-mitigated
libraries provided by Visual Studio.

Change-Id: I8294395659354f3ce60a355622da4b026abcceba
Reviewed-on: https://chromium-review.googlesource.com/c/external/gyp/+/4265144
Reviewed-by: Mark Mentovai <email address hidden>

2170. By Marcin Radomski <email address hidden>

Import OrderedDict from collections, not collections_abc

This was a mistake introduced in
https://chromium-review.googlesource.com/c/external/gyp/+/3536247 that
broke Windows breakpad build. See
https://github.com/chromium/gyp/commit/bc83cdacf5428ab6ddcc92fd0b0fc494cc9a4d4f#commitcomment-75762564

Bug: b/217559564
Change-Id: I3e44da6f4e40ad062106877f24021b5039a458b2
Reviewed-on: https://chromium-review.googlesource.com/c/external/gyp/+/3706740
Reviewed-by: Mark Mentovai <email address hidden>

2169. By Marcin Radomski <email address hidden>

gyp: default to python3 if available

Python2 was sunsetted in 2020. Google3 gyp fork already defaults to
python3, this patch brings it closer to upstream.

Bug: 227327945
Change-Id: Ia7f5c856355fa4d012dfc5b03ec0bc3f605ea407
Reviewed-on: https://chromium-review.googlesource.com/c/external/gyp/+/3562924
Reviewed-by: Mark Mentovai <email address hidden>

2168. By Marcin Radomski <email address hidden>

MSVSVersion.py: add support for VS2019 and VS2022

Add definitions for VS2019 and VS2022, use some additional environment
variables set by VS command prompt or vcvars*.bat scripts when looking
for VS installation path.

Bug: 227327945
Change-Id: I2b735c0d272312aacea6227ad53e61b4deaad7e7
Reviewed-on: https://chromium-review.googlesource.com/c/external/gyp/+/3557380
Reviewed-by: Mark Mentovai <email address hidden>

2167. By Marcin Radomski <email address hidden>

msvs_emulation.py: avoid string-int/float comparisons

This silently does a wrong thing on python2 (compares *type names*
instead of values, see "Objects of different types" note on
https://docs.python.org/2/library/stdtypes.html#comparisons), and throws
TypeError on python3.

Bug: 227327945
Change-Id: I70c831151f1eafde87b01a34b9d192785840ea3b
Reviewed-on: https://chromium-review.googlesource.com/c/external/gyp/+/3557379
Reviewed-by: Mark Mentovai <email address hidden>

2166. By Marcin Radomski <email address hidden>

Fix python3 compatibility on windows

* Use six.ensure_bytes in pylib/py/generator/ninja.py
* Pass universal_newlines=True to subprocess.Popen calls in
  pylib/gyp/win_tool.py and pylib/gyp/msvs_emulation.py, so that
  captured stdout is read as string instead of as raw bytes
* Replace str.translate calls with re.sub. Python3 doesn't support this
  str.translate with two arguments. re.sub() works the same in python2
  and 3.

Note: six.ensure_binary requires six>=1.15.0 (released 2020-05-21).

Bug: 227327945
Change-Id: I750a290b865bc6d9555f833237b72b9f3efa3b69
Reviewed-on: https://chromium-review.googlesource.com/c/external/gyp/+/3557378
Reviewed-by: Mark Mentovai <email address hidden>

2165. By Marcin Radomski <email address hidden>

msvs_emulation.py: allow skipping path normalization

Allow skipping path normalization when
GYP_MSVS_DISABLE_PATH_NORMALIZATION environment variable is set.

The normalization, introduced in
https://chromium-review.googlesource.com/c/external/gyp/+/482580,
turned out to break Mozc IME Windows build. Mozc ended up having to work
around this by applying a custom patch in its build process
(https://github.com/google/mozc/blob/fc9355039c48f11a15f9859a3ee72e228f6af827/src/gyp/gyp.patch#L21).

This CL is a part of the effort to get rid of the custom gyp patch from
Mozc repo.

Bug: 227327945
Change-Id: I18560d283a5152d8988a55965586c3d1aeabf7af
Reviewed-on: https://chromium-review.googlesource.com/c/external/gyp/+/3557377
Reviewed-by: Mark Mentovai <email address hidden>

2164. By Marcin Radomski <email address hidden>

Use six.moves.collections_abc where appropriate

Some classes from collections module were moved to collections.abc in
Python 3.3.

This came up when trying to compile Mozc on Windows. That enables gyp to
work with Python 3.3+ on Windows. I also looked for other potentially
problematic places and updated them as well.

Bug: 217559564
Change-Id: I8a573fa8e5a21caf2a6a5b068d3412986f660da3
Reviewed-on: https://chromium-review.googlesource.com/c/external/gyp/+/3536247
Reviewed-by: Mark Mentovai <email address hidden>

2163. By Dirk Pranke <email address hidden>

Remove Travis integration, since GYP is now idle.

Change-Id: I09bcd81f961d8d69a6712470ffc84cea81ed76ad
Reviewed-on: https://chromium-review.googlesource.com/c/external/gyp/+/3131841
Reviewed-by: Michael Moss <email address hidden>

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.

Subscribers

No subscribers.