lp:~itachi-san/telegram-desktop/gyp

Created by Giovanni Santini on 2016-12-19 and last modified on 2019-04-18
Get this branch:
bzr branch lp:~itachi-san/telegram-desktop/gyp

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Giovanni Santini
Project:
Telegram Desktop
Status:
Development

Import details

Import Status: Reviewed

This branch is an import of the HEAD branch of the Git repository at https://chromium.googlesource.com/external/gyp.

The next import is scheduled to run in 7 minutes.

Last successful import was 5 hours ago.

Import started 5 hours ago on izar and finished 5 hours ago taking 20 seconds — see the log
Import started 11 hours ago on alnitak and finished 11 hours ago taking 15 seconds — see the log
Import started 17 hours ago on izar and finished 17 hours ago taking 20 seconds — see the log
Import started 23 hours ago on alnitak and finished 23 hours ago taking 20 seconds — see the log
Import started on 2019-05-22 on izar and finished on 2019-05-22 taking 20 seconds — see the log
Import started on 2019-05-22 on alnitak and finished on 2019-05-22 taking 15 seconds — see the log
Import started on 2019-05-22 on izar and finished on 2019-05-22 taking 20 seconds — see the log
Import started on 2019-05-22 on izar and finished on 2019-05-22 taking 20 seconds — see the log
Import started on 2019-05-21 on alnitak and finished on 2019-05-21 taking 15 seconds — see the log
Import started on 2019-05-21 on izar and finished on 2019-05-21 taking 20 seconds — see the log

Recent revisions

2154. By Tobias on 2019-04-18

Fix incorrect depfile path relativization

While 'gyp dictates that commands are run from the base directory'
(ninja.py:1613), ninja still expects the depfile path for the depfile
that this command will create to be relative to the build directory.

If the depfile argument doesn't contain special paths like
<(PRODUCT_DIR), <(SHARED_INTERMEDIATE_DIR) or <(INTERMEDIATE_DIR),
ExpandSpecial returns its argument unchanged.

If it does contain one of these special paths, on the other hand, ninja
will never find the correct depfile without this fix.

Bug: 549
Change-Id: Idfae9dd1e7134720c5ce19fc8e4f877dde796d56
Reviewed-on: https://chromium-review.googlesource.com/c/external/gyp/+/1561250
Reviewed-by: Mark Mentovai <email address hidden>

2153. By Dirk Pranke <email address hidden> on 2019-04-01

Add flake8 checks to travis configuration.

This should give us some coverage for python3 compatibility and extra
checking beyond the unit tests.

Thanks <email address hidden> for the patch! (see
https://github.com/chromium/gyp/pull/1)

Bug: gyp:36
Change-Id: I50fae17776d417daeb876ff56d83649c27b16393
Reviewed-on: https://chromium-review.googlesource.com/c/external/gyp/+/1368753
Reviewed-by: Mark Mentovai <email address hidden>

2152. By Jared Wyles <email address hidden> on 2019-03-01

Changes for windows and easy xml to get gyp to run under python 3.

These changes come from our (adobes) changes to the gyp to get it to run under python 3. These are mostly windows changes but 1 change to easyxml due to decode no longer being supported on str.

Change-Id: I65fadc03c2acd079d5536159d4c13a28549c89a7
Reviewed-on: https://chromium-review.googlesource.com/c/1475053
Reviewed-by: Mark Mentovai <email address hidden>

2151. By Dirk Pranke <email address hidden> on 2018-12-10

More miscellaneous fixes for Python3 compatibility.

This patch fixes a bunch of stuff flake8 revealed (thanks to
<email address hidden> for the tip!) and a few dangling print
statements (thanks to <email address hidden> for the tip!).

Bug: gyp:36
Change-Id: Ie24cdda2613c7d76bf06875f9de435e001a3e8b6
Reviewed-on: https://chromium-review.googlesource.com/c/1368752
Reviewed-by: Mark Mentovai <email address hidden>
Reviewed-by: Dirk Pranke <email address hidden>

2150. By Refael on 2018-12-10

src,win: add VS2019 version

PR-URL: https://github.com/refack/GYP/pull/13
Change-Id: Idcdd59570195efb06285d5114328d74bd8f6d732
Reviewed-on: https://chromium-review.googlesource.com/c/1369264
Reviewed-by: Mark Mentovai <email address hidden>

2149. By Dirk Pranke <email address hidden> on 2018-12-08

Fixes needed for Python3 on Win32.

This CL contains the remaining fixes needed for the tests to
pass when running under Python 3.7 on Win10. Mostly these
are just changes to convert the output of subprocesses to
strings, but there are a few other minor compatibility fixes
as well.

With this CL, Python 3 should work everywhere we support it.
Python 2 continues to work as well.

Bug: gyp:36
Change-Id: Ie696a1845fb2dba4d86929be886becc5d300ef7a
Reviewed-on: https://chromium-review.googlesource.com/c/1365010
Reviewed-by: Mark Mentovai <email address hidden>

2148. By Dirk Pranke <email address hidden> on 2018-12-04

Fix one dangling utf8 decode call needed for python 3.

With this change, the tests should run fine on Python3 on Macs.
Python2 should work fine as well :).

Bug: gyp:36
Change-Id: I044746d44143b2e461feb4e5685d8bef3d6bbd19
Reviewed-on: https://chromium-review.googlesource.com/c/1361812
Reviewed-by: Mark Mentovai <email address hidden>

2147. By Dirk Pranke <email address hidden> on 2018-12-04

Mostly mechanical changes for Python3 support.

Everything should still work fine in Python 2. With this change (and
the others I've just landed), Python 3 should work on at least
Linux, but I need to do more sanity-checking on Mac and Win.

The changes in this CL are all mechanical -- things like
print() instead of print, `key in dict` rather than dict.has_key(key),
and switching to use .decode('utf8') to handle the binary streams
returned from a subprocess (and a few other things).

Most of this work is derived from <email address hidden>'s
original work in https://codereview.chromium.org/1454433002/.

Bug: gyp:36

Change-Id: Ie04ebcf2d82e7b8ff34c6a112215eac46af688ba
Reviewed-on: https://chromium-review.googlesource.com/c/1357805
Reviewed-by: Mark Mentovai <email address hidden>

2146. By Dirk Pranke <email address hidden> on 2018-12-04

Update simple_copy.py for Python3 types.

Python 3 gets rid of 'str', 'long', so the file needed to be
tweaked slightly.

Bug: gyp:36
Change-Id: I7c820dfd6dfb5bfcf1a8ed315d67095557822757
Reviewed-on: https://chromium-review.googlesource.com/c/1360353
Reviewed-by: Mark Mentovai <email address hidden>

2145. By Dirk Pranke <email address hidden> on 2018-12-04

Use ast module instead of compiler module for parsing files.

This CL is part of the work getting GYP to run under Python 3.
The compiler module we used to parse GYP files was removed in
Python 3, so this CL switches to use the ast module instead,
which exists in both Python 2 and Python 3.

This change is not sufficient to run under Python 3; there's
more work remaining. Things should still work under Python 2
just fine.

This work is derived from <email address hidden>'s
original work in https://codereview.chromium.org/1454433002/.

Bug: gyp:36

Change-Id: I9a9835560491c3d8cd5426623484dc4a46af1d86
Reviewed-on: https://chromium-review.googlesource.com/c/1360352
Reviewed-by: Mark Mentovai <email address hidden>

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.

Subscribers

No subscribers.