lp:~itachi-san/telegram-desktop/breakpad

Created by Giovanni Santini on 2016-05-04 and last modified on 2019-12-05
Get this branch:
bzr branch lp:~itachi-san/telegram-desktop/breakpad

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Giovanni Santini
Project:
Telegram Desktop
Status:
Development

Import details

Import Status: Reviewed

This branch is an import of the HEAD branch of the Git repository at https://chromium.googlesource.com/breakpad/breakpad.

The next import is scheduled to run in 47 minutes.

Last successful import was 5 hours ago.

Import started 5 hours ago on alnitak and finished 5 hours ago taking 20 seconds — see the log
Import started 11 hours ago on alnitak and finished 11 hours ago taking 20 seconds — see the log
Import started 17 hours ago on alnitak and finished 17 hours ago taking 20 seconds — see the log
Import started 23 hours ago on alnitak and finished 23 hours ago taking 20 seconds — see the log
Import started on 2019-12-06 on izar and finished on 2019-12-06 taking 20 seconds — see the log
Import started on 2019-12-06 on izar and finished on 2019-12-06 taking 20 seconds — see the log
Import started on 2019-12-05 on alnitak and finished on 2019-12-05 taking 20 seconds — see the log
Import started on 2019-12-05 on alnitak and finished on 2019-12-05 taking 20 seconds — see the log
Import started on 2019-12-05 on izar and finished on 2019-12-05 taking 20 seconds — see the log
Import started on 2019-12-05 on alnitak and finished on 2019-12-05 taking 20 seconds — see the log

Recent revisions

1811. By Nelson Billing <email address hidden> on 2019-12-05

Enable reading DWARF4 CIEs with 32 bit addresses.

- Reading DWARF4 CIEs was added in
https://chromium-review.googlesource.com/c/breakpad/breakpad/+/406012 but it
was only enabled for 64bit builds, since it would error out if the CIE
address size was not 8 bytes.
- Added a unit test to ensure that 32bit continues to work.

Change-Id: I824bb40cdf12056d39da335adb55ed315970fb88
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1941034
Reviewed-by: Ivan Penkov <email address hidden>
Reviewed-by: Mark Mentovai <email address hidden>

1810. By Bryan Klimt <email address hidden> on 2019-12-04

Add a variable to allow adding an extra include path for LSS.

I have a project where we are trying to include breakpad as a git
submodule. The only problem getting it to build with ndk-build is that
the linux_syscall_support.h header is missing. Normally, this header
would be downloaded by the depot_tools. But we cannot install
depot_tools on our CI machines.

So, we would like to include the header as a separate submodule in our
repo. The only change we would need to make to breakpad to make that
work is to add this optional variable to the C header search path. In
the normal case, this variable will not be set and nothing will be
different. But we can set the variable to allow us to build without
installing depot_tools.

I have manually tested this using a separate project that links to
breakpad in this way.

Change-Id: Id116b2af1c1ba0a08464c213d8982b24a1821ee7
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1930179
Reviewed-by: Mark Mentovai <email address hidden>

1809. By Mark Mentovai <email address hidden> on 2019-12-02

dump_syms: handle forward reference DWARF attributes

DW_AT_specification and DW_AT_abstract_origin attributes carry
references to other DIEs. Nothing prevents the DIEs referred to from
appearing later in .debug_info than the DIE containing the referring
attribute, but dump_syms incompletly implemented its handling of these
references, and was only able to resolve them when they were
back-references.

This will fix the chronic warnings produced by dump_syms of the form:

dump_syms: the DIE at offset <offset> has a {DW_AT_specification,
DW_AT_abstract_origin} attribute referring to the die at offset
<offset>, which either was not marked as {a declaration, an inline}, or
comes later in the file

Patch by Greg Clayton

Bug: breakpad:441
Change-Id: I98957d64a234c22afb6d0153f1bdc09e6a600b1d
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1946706
Reviewed-by: Mark Mentovai <email address hidden>

1808. By Jon TURNEY on 2019-11-22

Fix compilation of http_upload.cc with Windows gcc

Fix compilation of http_upload.cc with Windows gcc after 548ca6e3, by
moving the definition of GetFileContents(), so it comes after the
definition of WideToMBCP(), which it uses (under !_MSC_VER).

common/windows/http_upload.cc: In function ‘bool {anonymous}::GetFileContents(const wstring&, std::vector<char>*)’:
common/windows/http_upload.cc:80:19: error: ‘WideToMBCP’ was not declared in this scope

Change-Id: I1646b39263e97bbf3bd8cb1ae209be238023110f
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1928929
Reviewed-by: Mike Frysinger <email address hidden>

1807. By Mark Mentovai <email address hidden> on 2019-11-22

mac processor: Add mapping for EXC_BAD_ACCESS/KERN_CODESIGN_ERROR

This code indicates termination under “kill” semantics due to a module’s
code signature becoming invalid.

Bug: chromium:1023239
Change-Id: I3d453af9ef6c6925edcf9c08dbd78e563877522f
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1930177
Reviewed-by: Robert Sesek <email address hidden>

1806. By Jon TURNEY on 2019-11-19

Fix 'make distcheck'

Update EXTRA_DIST to allow 'make distcheck' to work

Change-Id: I2f840e6e86039d590af601a55e20fb9f6caf3a08
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1924253
Reviewed-by: Mike Frysinger <email address hidden>

1805. By Sylvain Defresne <email address hidden> on 2019-11-12

Remove dependency of uploader.mm on GTMLogger

The file GTMLogger shipped with breakpad is a copy of the version
from google_toolbox_for_mac. Having uploader.mm depend on GTMLogger
causes pain to iOS projects that want to integrate both breakpad
and google_toolbox_for_mac.

Since the file uploader.mm mixed uses of fprintf and GTMLogger to
log errors and warning, convert it to only use fprintf to stderr.

Bug: none
Change-Id: I68313ccf6951676a2859f44225281813722096ba
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1911755
Reviewed-by: Mark Mentovai <email address hidden>

1804. By Christopher Grant <email address hidden> on 2019-11-05

Add fallthrough annotations on new C++ switches

A recent commit converted some source from C to C++. Chrome has
checks against unannotated switch case fallthroughs in C++ code, so the
converted source needs annotations.

Bug: 990190
Change-Id: Ib92435b4877be936f837928a70b552ec4975d42a
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1898429
Reviewed-by: Mark Mentovai <email address hidden>
Reviewed-by: Mike Frysinger <email address hidden>

1803. By Mark Mentovai <email address hidden> on 2019-11-01

Revert "Remove use of "register" keyword, deprecated in C++17"

This reverts commit 07411862eaa9a9a38e84caed2e97e836e456656f.

We were a bit overzealous in removing “register” here. Both clang and
GCC correctly disallow “register” as a storage class specifier in C++17
mode by producing an error in ordinary use. However, they require
“register” to be specified for explicit register variables, and do not
produce an error in this case.

Change-Id: I223f2652c6da4215d6e8788d902e767c94b8c29d
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1894875
Reviewed-by: Mark Mentovai <email address hidden>

1802. By Joshua Peraza <email address hidden> on 2019-10-30

linux, client: set module name from DT_SONAME

3e56ef9d changed dump_syms to set the module name from DT_SONAME
expecting that clients were already using DT_SONAME when it was
present. The Breakpad client previously only used DT_SONAME as the name
for a module if it detected that it was likely mapped from a zip file.
This patch updates the Breakpad Linux client to always use the
DT_SONAME in minidumps if it's present.

Also included are changes to address comments that were missed from
that review.

Bug: 1016924
Change-Id: I4aae8c05e6793d4b0598049a8964ddd4cb0c6194
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1889231
Reviewed-by: Mark Mentovai <email address hidden>
Reviewed-by: Mike Frysinger <email address hidden>

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.

Subscribers

No subscribers.