lp:~itachi-san/telegram-desktop/breakpad

Created by Giovanni Santini and last modified
Get this branch:
bzr branch lp:~itachi-san/telegram-desktop/breakpad

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Giovanni Santini
Project:
Telegram Desktop
Status:
Development

Import details

Import Status: Reviewed

This branch is an import of the HEAD branch of the Git repository at https://chromium.googlesource.com/breakpad/breakpad.

The next import is scheduled to run .

Last successful import was .

Import started on juju-98ee42-prod-launchpad-codeimport-2 and finished taking 25 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-1 and finished taking 30 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-0 and finished taking 25 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-5 and finished taking 25 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-4 and finished taking 40 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-4 and finished taking 25 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-3 and finished taking 25 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-3 and finished taking 25 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-2 and finished taking 20 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-2 and finished taking 20 seconds — see the log

Recent revisions

2253. By Ivan Penkov <email address hidden>

Adding freshly built binaries for Windows.

Change-Id: I74f52697272427d08a678ceb0a835aed7f57a540
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/7104018
Reviewed-by: Joshua Peraza <email address hidden>

2252. By Ivan Penkov <email address hidden>

Remove unnecessary static_casts in exception handling.

The switch statements on `exception_information[0]` do not
require casting to enum types, as the case labels are already
the integer values of the enum members.

Upstreaming this fix from Google.

Bug: b:452247353
Change-Id: I22e4a4394cdfa405e6ef94548961cdad37eb78a6
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/7069979
Reviewed-by: Mark Mentovai <email address hidden>

2251. By Ivan Penkov <email address hidden>

Better handling of invalid raw exception subcode.

There should be no functional change. If the subcode is invalid it
will continue to default to reason: 'EXCEPTION_STACK_BUFFER_OVERRUN'

Fixing it because some validation tool are complaining of assigning
invalid enum value to a local variable.

Change-Id: I115c46e049517fa261e69b551cfaddb63ea3170a
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/7047357
Reviewed-by: Mark Mentovai <email address hidden>

2250. By Ivan Penkov <email address hidden>

Fix potential integer overflow in `my_strtoui`.

The `my_strtoui` function now includes checks to prevent integer
overflow when parsing a string to an integer, using
`std::numeric_limits<int>::max()` from `<limits>`.

Also, renamed `my_strtoui` to `my_strtoi_nonneg` because the
function seems like `my_strtoi`, except it doesn’t handle
negative int.

Bug: b: 366998442
Change-Id: I7e0ed2344ae09e886debe286cc0df759218506bc
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/7045910
Reviewed-by: Mark Mentovai <email address hidden>

2249. By Ivan Penkov <email address hidden>

Validate platform_id in Minidump::GetPlatform.

The `Minidump::GetPlatform` function now checks if
`system_info->platform_id` corresponds to a known `MDOSPlatform`
value before casting and returning true. This prevents returning an
invalid platform for unknown or unexpected platform IDs.

Bug: b: 366998442
Change-Id: I0db806cc5047ea6a772179f36fc1289a6418f930
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/7045913
Reviewed-by: Mark Mentovai <email address hidden>

2248. By Victor Hugo Vianna Silva <email address hidden>

Fix C++23 build error

DwpReader needs to be a complete type before it can be manipulated with
unique_ptrs. Move the definition up in the file.

Bug: 388068055
Change-Id: Ic9cef83febae638b7dcff9585d9dfe0ed64654b9
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/7013549
Reviewed-by: Lei Zhang <email address hidden>

2247. By Eric Long <email address hidden>

breakpad_getcontext: fix RISC-V gp

Fix a typo that accidentally stores gp into sp and overrides it.

Change-Id: If89e7b8a8a04330332996cc7133d1a2f997323c7
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/6976663
Reviewed-by: Levi Zim <email address hidden>
Reviewed-by: Mike Frysinger <email address hidden>

2246. By chromium-autoroll <email address hidden>

Roll LSS from ed31caa60f20 to 29164a80da4d (1 revision)

https://chromium.googlesource.com/linux-syscall-support.git/+log/ed31caa60f20..29164a80da4d

2025-10-02 <email address hidden> Override fstatat64 macro

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/lss-breakpad-autoroll
Please CC <email address hidden>,<email address hidden>,<email address hidden> on the revert to ensure that a human
is aware of the problem.

To file a bug in Breakpad: https://bugs.chromium.org/p/linux-syscall-support/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: <email address hidden>,<email address hidden>
Change-Id: I56ad6bf7cb47468030b10b3bb8e9c66a8b1027c5
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/7006897
Reviewed-by: Ivan Penkov <email address hidden>
Reviewed-by: Mike Frysinger <email address hidden>

2245. By Ivan Penkov <email address hidden>

Remove the LICENSE for musl.

Not needed anymore and causes problems with compliance tools.
For more information, please take a look at
https://chromium.googlesource.com/breakpad/breakpad/+/e57d89afb3f786e58bb8c8ddbd3c10a9b83adae6

Change-Id: I99b729619bfeda0c800c166c8e708f688b32e811
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/6990217
Reviewed-by: Mark Mentovai <email address hidden>

2244. By Ivan Penkov <email address hidden>

Remove musl COPYRIGHT file from Breakpad

This file is being removed because its presence confuses LICENSE
compliance tooling. According to the musl license
(see https://git.musl-libc.org/cgit/musl/tree/COPYRIGHT), the copyright
notice is not required when only using the header files under
`include/`, which is the case for Breakpad.

Keeping this file causes the compliance tool to incorrectly flag that
the full musl COPYRIGHT text needs to be included in Breakpad's main
LICENSE file. This is problematic because the tool then doesn't
recognize the category (permissiveness) for the license.

```
In addition, permission is hereby granted for all public header files
(include/* and arch/*/bits/*) and crt files intended to be linked into
applications (crt/*, ldso/dlstart.c, and arch/*/crt_arch.h) to omit
the copyright notice and permission notice otherwise required by the
license, and to use these files without any requirement of
attribution. These files include substantial contributions from:

Bobby Bingham
John Spencer
Nicholas J. Kain
Rich Felker
Richard Pennington
Stefan Kristiansson
Szabolcs Nagy

all of whom have explicitly granted such permission.
```

Change-Id: Iaf1c886a0cfb11a9441905746857aada79d7f9e1
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/6990774
Reviewed-by: Joshua Peraza <email address hidden>
Reviewed-by: Mark Mentovai <email address hidden>

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.

Subscribers

No subscribers.