lp:~itachi-san/telegram-desktop/breakpad

Created by Giovanni Santini on 2016-05-04 and last modified on 2020-03-19
Get this branch:
bzr branch lp:~itachi-san/telegram-desktop/breakpad

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Giovanni Santini
Project:
Telegram Desktop
Status:
Development

Import details

Import Status: Reviewed

This branch is an import of the HEAD branch of the Git repository at https://chromium.googlesource.com/breakpad/breakpad.

The next import is scheduled to run in 4 hours.

Last successful import was 1 hour ago.

Import started 1 hour ago on izar and finished 1 hour ago taking 20 seconds — see the log
Import started 7 hours ago on alnitak and finished 7 hours ago taking 20 seconds — see the log
Import started 13 hours ago on izar and finished 13 hours ago taking 20 seconds — see the log
Import started 19 hours ago on alnitak and finished 19 hours ago taking 20 seconds — see the log
Import started on 2020-03-27 on alnitak and finished on 2020-03-27 taking 20 seconds — see the log
Import started on 2020-03-27 on alnitak and finished on 2020-03-27 taking 20 seconds — see the log
Import started on 2020-03-26 on izar and finished on 2020-03-26 taking 25 seconds — see the log
Import started on 2020-03-26 on izar and finished on 2020-03-26 taking 20 seconds — see the log
Import started on 2020-03-26 on alnitak and finished on 2020-03-26 taking 20 seconds — see the log
Import started on 2020-03-26 on izar and finished on 2020-03-26 taking 20 seconds — see the log

Recent revisions

1839. By Michael Forney on 2020-03-19

Remove true/false defines in convert_UTF.cc

These are left over from when this file was written in C.

In C++, true and false are keywords, so this is no longer necessary.
In fact, redefining a keyword is not actually permitted in ISO C++
(https://eel.is/c++draft/macro.names#2), and is rejected by MSVC.

Change-Id: I2f4a6eae7f8dd4d91b8ee6588c7ae5e8f20bd0d0
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2105831
Reviewed-by: Mike Frysinger <email address hidden>

1838. By Michael Forney on 2020-03-17

Use ULONG_MAX instead of __WORDSIZE to determine native ELF architecture

__WORDSIZE is an internal libc definition. Instead, we can use
ULONG_MAX from limits.h, whose value corresponds to the machine's
native word size.

This allows us to remove the fallback definition of __WORDSIZE in
the Android compatibility headers.

Bug: google-breakpad:631
Change-Id: I7b9e6f3b2121f78ccad9e32bf26acac518aefd8f
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2107100
Reviewed-by: Mike Frysinger <email address hidden>

1837. By Michael Forney on 2020-03-17

Roll src/src/third_party/lss/ f70e2f164..fd00dbbd0 (2 commits)

https://chromium.googlesource.com/linux-syscall-support/+log/f70e2f1641e2..fd00dbbd0c06

$ git log f70e2f164..fd00dbbd0 --date=short --no-merges --format='%ad %ae %s'
2020-03-10 mforney Avoid conflict with getdents64 defined by libc
2019-01-26 vapier futex: change to 6 args

Created with:
  roll-dep src/src/third_party/lss

Bug: google-breakpad:631
Change-Id: Icc248237dcc7bdc3f7b74cd8556efcaf3b4b1c31
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2106526
Reviewed-by: Mike Frysinger <email address hidden>

1836. By Michael Forney on 2020-03-16

Use breakpad_getcontext on all Linux platforms missing getcontext

getcontext is also not available on musl libc, so generalize
breakpad_getcontext so it can be used as a fallback for non-Android
platforms as well.

On x86_64 and i386, ucontext_t uses an Android-specific offset for
storage of FP registers, since its sigset_t differs in size. So,
make the definition of MCONTEXT_FPREGS_MEM and UCONTEXT_FPREGS_MEM_OFFSET
conditional on whether we are building for Android.

On glibc and musl, signal.h and asm/sigcontext.h can't be included
together, so in breakpad_context_unittest.cc, only compare the libc
and kernel _fpstate when on Android.

Bug: google-breakpad:631
Change-Id: If81d73c4101bae946e9a3655b8d1c40a34ab6c38
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2102135
Reviewed-by: Mike Frysinger <email address hidden>

1835. By Mike Frysinger <email address hidden> on 2020-03-14

convert_UTF: try to update xcode files

Bug: google-breakpad:725
Change-Id: I8c5f9a828e1bb6a2a5603fbfaa127f6dfe64a4b4
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1803770
Reviewed-by: Mark Mentovai <email address hidden>

1834. By Michael Forney on 2020-03-13

Fix some bugs in CheckMicrodumpContents

The crash address from the microdump was never checked against
anything. Instead, the test was checking the value of a constant.

On 32-bit systems, an intptr_t cannot represent kCrashAddress
(0xDEADDEAD), causing a failure when the crash address is parsed
from the microdump. Instead, use uintptr_t, which matches the type
of kCrashAddress.

Change-Id: Ib5612743803609f7801dcfb98deaa8779e362025
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2100816
Reviewed-by: Mike Frysinger <email address hidden>

1833. By Michael Forney on 2020-03-11

Remove sys/signal.h compatibility header

Since a03ad96dbd, sys/signal.h is no longer required.

Change-Id: I64e6235e1bffb3728d6050389bad6e7a99389741
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2097666
Reviewed-by: Mike Frysinger <email address hidden>

1832. By Michael Forney on 2020-03-11

Add google_crashdump_uploader_test to .gitignore

Change-Id: I5c5e5c85ec49a76e5f4c7c6a0f662398e6cdc6ee
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2097681
Reviewed-by: Mike Frysinger <email address hidden>

1831. By Michael Forney on 2020-03-11

Remove redundant LINUX_HOST conditional

We are already in a LINUX_HOST conditional block, so there is no need
to check for it again.

Change-Id: Ifbe283ffa47373c98d2653f1014445d1a435c715
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2093144
Reviewed-by: Mike Frysinger <email address hidden>

1830. By Michael Forney on 2020-03-10

Use public fpregset_t type to define fpstate_t

The _libc_fpstate struct tag is an implementation detail of glibc,
and musl uses a different struct tag, _fpstate.

Unfortunately, the public type fpregset_t is a pointer type, so is
not suitable for allocating storage, or referring to constant
storage. Instead, we can use std::remove_pointer<fpregset_t>::type
to refer to the pointed-to type, regardless of the struct tag.

Bug: google-breakpad:631
Change-Id: Iaf47f15b2d834dd8de839431f65a481e9b0c7f9e
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2096171
Reviewed-by: Mike Frysinger <email address hidden>

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.

Subscribers

No subscribers.