lp:~itachi-san/telegram-desktop/breakpad

Branch merges

This import branch has no branches proposed for merge into it.

No branches dependent on this one.

Related source package recipes

1 recipe using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

2195. By Tom Burgin <email address hidden> 6 hours ago

Revert "[windows] Silence MSVC warning C4100 when building without zlib support"

This reverts commit ee94d7f24bf1ac756c8db20b6d9e052acaa17e0c.

Reason for revert: Breaks Windows builds of Chromium.

https://ci.chromium.org/ui/p/chromium/builders/try/win-rel/695756/overview

Original change's description:
> [windows] Silence MSVC warning C4100 when building without zlib support
>
> Bug: b/354710760
> Change-Id: I0a5771795ca456cd07ad26038f005553875df641
> Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5735099
> Reviewed-by: Ivan Penkov <email address hidden>
> Reviewed-by: Ivan Penkov <email address hidden>

Bug: b/354710760
Change-Id: Ib49e06944934d467beaefb91411235eed020381a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5742385
Reviewed-by: Ivan Penkov <email address hidden>

2194. By Tom Burgin <email address hidden> 10 hours ago

upload_system_symbols: break into go packages

This will make reusing this code easier. Since there are multiple
packages now, the build needs updating. A separate CL in Chromium will
follow this change.

Change-Id: I8d95d13ea61d32684d0ef845c3d1da2cd6d4cd7f
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5742415
Reviewed-by: Mark Mentovai <email address hidden>
Reviewed-by: Leonard Grey <email address hidden>

2193. By Greg Thompson <email address hidden> on 2024-07-25

[windows] Silence MSVC warning C4100 when building without zlib support

Bug: b/354710760
Change-Id: I0a5771795ca456cd07ad26038f005553875df641
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5735099
Reviewed-by: Ivan Penkov <email address hidden>
Reviewed-by: Ivan Penkov <email address hidden>

2192. By Greg Thompson <email address hidden> on 2024-07-19

[windows] Include-what-you-use fixes in http_upload.{cc,h}

Bug: b/353869880
Change-Id: I7dd2d432032099c77410ce67a0fce6c7a71b473f
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5720428
Reviewed-by: Ivan Penkov <email address hidden>

2191. By Sean Carpenter <email address hidden> on 2024-07-17

Adds NDS32 Architecture Support to dump_syms

NDS32 is a relatively uncommon architecture that is used on a
significant chunk of our ChromeOS EC Microprocessors. NDS32 symbol table
generation was already supported, but would fail due to "Unrecognized ELF
machine architecture". This change fixes that.

TEST=dump_syms -a some.nds32.elf
BUG=b:328511413

Change-Id: I3e9ae900be483c957a824166d24e2d5db240b64a
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5718928
Reviewed-by: Forest Mittelberg <email address hidden>
Reviewed-by: Ivan Penkov <email address hidden>

2190. By Greg Thompson <email address hidden> on 2024-07-12

[Windows] PDBSourceLineWriter improvements

COM calls that return a BSTR via an out param pass ownership of the
string's underlying memory to the caller. It is the caller's
responsibility to free the memory via SysFreeString. Be sure to use
CComBSTR in all such cases, so that this happens upon destruction of the
CComBSTR. This CL fixes three BSTR memory leaks.

The inline_origins_ member maps an inline origin's name to a unique
numerical identifier. Simplify the container by mapping a name only to
an id rather than a name to a struct holding the name and id.

These origins are printed ordered by id. Rather than using a std::set to
create a container sorted by id, leverage the fact that ids are ints
that are assigned sequentially to create the reverse mapping in a
std::vector. This greatly reduces heap usage, and reduces complexity to
O(N).

Combined, these changes reduce commit charge by 26% and runtime by 10%
when processing chrome.dll for a 32-bit win-dcheck build.

Change-Id: Ib8d6540c74622500989f1dc06f705d6846be303f
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5682242
Reviewed-by: Ivan Penkov <email address hidden>

2189. By Greg Thompson <email address hidden> on 2024-07-12

[symupload] Upload compressed symbol files on Windows

When supported at build-time (by defining HAVE_ZLIB and ensuring that
zlib.h is in the include path), use zlib to deflate symbol files before
uploading. In case of failure (or when not supported), fall-back to
uploading the raw data as before.

Bug: chromium:349736158
Change-Id: I9345b87e42a03c87a43247e418b5cc05cd19b2b5
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5701147
Reviewed-by: Ivan Penkov <email address hidden>

2188. By Greg Thompson <email address hidden> on 2024-07-08

[symupload] Log details to stderr on failure

On success, symupload emits details such as the debug identifier. Emit a
very similar message to stderr on failure, as this information may also
be useful when diagnosing upload failures.

Bug: chromium:349736158
Change-Id: Ic3b5316283e4603dca815bd85a2fd51516fbcca8
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5682842
Reviewed-by: Ivan Penkov <email address hidden>

2187. By Greg Thompson <email address hidden> on 2024-07-08

[symupload] Fix malformed Content-Type header

SendSimplePostRequest expects a complete message header for
Content-Type, not only the value.

Change-Id: Ib0b039d1a717c10f74b7e07caa8e4b544dff6cd1
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5682928
Reviewed-by: Ivan Penkov <email address hidden>

2186. By Greg Thompson <email address hidden> on 2024-07-05

[Windows] Improve diagnostic logging in HTTPUpload

Log the operation and Windows and/or WinInet error in case of failure.
Also remove use of an intermediate buffer in ReadResponse.

Bug: chromium:349736158
Change-Id: I51de506e1636e28a24a5c6dd579ebbfcd07c0345
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5679269
Reviewed-by: Primiano Tucci <email address hidden>