Code review comment for lp:~ipython-dev/ipython/set_trace

Revision history for this message
Fernando Perez (fdo.perez) wrote :

Hi Ondrej,

sorry for not having worked on this earlier...

What I don't understand is what the point of this feature is, when we already have the embedding classes as explained here:

http://ipython.scipy.org/doc/stable/html/interactive/reference.html#embedding

Your code basically reduces the code needed to embed ipython from 3 to 2 lines, but the existing machinery actually does it with much more flexibility. So I'd like to understand the justification for this feature better before considering it for merging. Ville's and Jorgen's comments still apply, but I'm actually wondering if we need this *at all*. It seems to me that we already have tools for this, though I may well be missing something and would be happy to reconsider.

review: Needs Information

« Back to merge proposal