Code review comment for lp:~ipython-dev/ipython/set_trace

Revision history for this message
Ondrej Certik (ondrej-certik) wrote :

> > > > This should probably not be in __init__.py. It is intended for those who
> > > embed
> > > > ipython, i.e. public api. Therefore it should be in ipapi.py.
> > >
> > > Many thanks for the review, I'll fix it. Should I fix it by adding a new
> > > commit, or by changing the last commit (how can this be done with bzr?)?
> >
> > Just continue committing to this branch and push. You can't amend the old
> > commit.
>
> Ok, I have moved it to IPython/ipapi.py. So now it has to be imported with:
>
> IPython.ipapi.set_trace()
>
> do you think I can even import it in IPython/__init__.py? Or should I not do
> that?
>
> One more question --- I would like to change my email in the last two commits,
> is there a way to do it in bzr? It uses ondrej@crow, but I'd like to use my
> real email address.

I have fix the emails, see the ipython list for how I did it.

« Back to merge proposal