Merge lp:~invitu/openerp-mgmtsystem/7-0_noreload_data into lp:openerp-mgmtsystem
Proposed by
invitu
on 2014-02-25
Status: | Merged |
---|---|
Approved by: | Guewen Baconnier @ Camptocamp on 2014-02-28 |
Approved revision: | 93 |
Merged at revision: | 93 |
Proposed branch: | lp:~invitu/openerp-mgmtsystem/7-0_noreload_data |
Merge into: | lp:openerp-mgmtsystem |
Diff against target: |
91 lines (+16/-16) 1 file modified
mgmtsystem_hazard/mgmtsystem_hazard_data.xml (+16/-16) |
To merge this branch: | bzr merge lp:~invitu/openerp-mgmtsystem/7-0_noreload_data |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel Reis | Approve on 2014-02-26 | ||
Maxime Chambreuil (http://www.savoirfairelinux.com) | Approve on 2014-02-25 | ||
Pedro Manuel Baeza | code review | 2014-02-25 | Approve on 2014-02-25 |
Review via email:
|
Description of the change
Some sample data should not be recreated if deleted
To post a comment you must log in.
lp:~invitu/openerp-mgmtsystem/7-0_noreload_data
updated
on 2014-02-25
invitu (invitu) wrote : | # |
Hello, thanks for your comment
noupdate="1" flag means "data are not updated but they might be recreated if they are deleted"
forcecreate="0" flag means "date are not recreated if they are deleted"
(cf Olivier Dony : http://
Pedro Manuel Baeza (pedro.baeza) wrote : | # |
Thank you very much for the clarification. One thing more that I learn on the reviews!
About the MP itself, I consider that the approach of no recreating deleted samples are OK to clean data, so I approve it.
Regards.
review:
Approve
(code review)
review:
Approve
Hi, thanks for the change, but if you set noupdate flag, I think forcecreate="0" is redundant, doesn't it?
Regards.