OpenERP Community Backports (Addons)

Merge lp:~invitu/ocb-addons/7.0-fix-1190444 into lp:ocb-addons

  1. 7.0-fix-1190444
  2. Merge into 7.0
Proposed by invitu
Status: Rejected
Rejected by: Stefan Rijnhart (Opener)
Proposed branch: lp:~invitu/ocb-addons/7.0-fix-1190444
Merge into: lp:ocb-addons
Diff against target: 23 lines (+2/-2)
2 files modified
account/account_report.xml (+1/-1)
sale/sale_report.xml (+1/-1)
To merge this branch: bzr merge lp:~invitu/ocb-addons/7.0-fix-1190444
Reviewer Review Type Date Requested Status
Stefan Rijnhart (Opener) Disapprove
Review via email: mp+170469@code.launchpad.net

Description of the change

[IMP] account/sale : some data should not be updated because they are part of customisation for the company

To post a comment you must log in.
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Like I wrote on the bug report, I think there are arguments in favour of such a change but it needs more discussion and coordination with SA. The changes would then need to be made for every report in the system. I would rather not merge this proposal at this point.

review: Disapprove
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Rejecting, as this is a very partial implementation of a fundamental change that needs more discussion.

review: Disapprove

Unmerged revisions

9279. By invitu

[IMP] account/sale : some data should not be updated because they are part of customisation for the company

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account/account_report.xml'
2--- account/account_report.xml 2013-04-19 07:41:35 +0000
3+++ account/account_report.xml 2013-06-20 00:36:25 +0000
4@@ -1,6 +1,6 @@
5 <?xml version="1.0" encoding="utf-8"?>
6 <openerp>
7- <data>
8+ <data noupdate="1">
9 <report auto="False" id="account_general_ledger" menu="False" model="account.account" name="account.general.ledger" rml="account/report/account_general_ledger.rml" string="General Ledger"/>
10 <report auto="False" id="account_general_ledger_landscape" menu="False" model="account.account" name="account.general.ledger_landscape" rml="account/report/account_general_ledger_landscape.rml" string="General Ledger"/>
11 <report auto="False" id="account_3rdparty_ledger" menu="False" model="res.partner" name="account.third_party_ledger" rml="account/report/account_partner_ledger.rml" string="Partner Ledger"/>
12
13=== modified file 'sale/sale_report.xml'
14--- sale/sale_report.xml 2011-10-10 14:38:06 +0000
15+++ sale/sale_report.xml 2013-06-20 00:36:25 +0000
16@@ -1,6 +1,6 @@
17 <?xml version="1.0" encoding="utf-8"?>
18 <openerp>
19- <data>
20+ <data noupdate="1">
21
22 <report auto="False" id="report_sale_order" model="sale.order" name="sale.order"
23 rml="sale/report/sale_order.rml" string="Quotation / Order"