Merge lp:~invitu/account-financial-report/8.0-account_financial_report_webkit into lp:~account-report-core-editor/account-financial-report/7.0

Proposed by invitu
Status: Needs review
Proposed branch: lp:~invitu/account-financial-report/8.0-account_financial_report_webkit
Merge into: lp:~account-report-core-editor/account-financial-report/7.0
Diff against target: 33 lines (+3/-2)
2 files modified
account_financial_report_webkit/report/open_invoices.py (+1/-1)
account_financial_report_webkit/report/webkit_parser_header_fix.py (+2/-1)
To merge this branch: bzr merge lp:~invitu/account-financial-report/8.0-account_financial_report_webkit
Reviewer Review Type Date Requested Status
Pedro Manuel Baeza Needs Resubmitting
Review via email: mp+216529@code.launchpad.net

Description of the change

Hello
I started to migrate account_financial_report_webkit to V8 (small changes)
Regards

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Hi, thanks for the MP.

Changes done are still compatible with v7?

Regards.

review: Needs Information
Revision history for this message
invitu (invitu) wrote :

hello

I just tested it and yes indeed, it still works with V7 :-)

regards

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

OK, you have my approval then.

Regards.

review: Approve (code review)
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

This project is now hosted on https://github.com/OCA/account-financial-reporting. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

This is very convenient to do before 8.0 branch creation

review: Needs Resubmitting

Unmerged revisions

87. By invitu

[MIG] portability to V8

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_financial_report_webkit/report/open_invoices.py'
2--- account_financial_report_webkit/report/open_invoices.py 2014-03-17 12:09:18 +0000
3+++ account_financial_report_webkit/report/open_invoices.py 2014-04-20 00:01:23 +0000
4@@ -37,7 +37,7 @@
5
6
7 def get_mako_template(obj, *args):
8- template_path = openerp.addons.get_module_resource(*args)
9+ template_path = openerp.modules.get_module_resource(*args)
10 return Template(filename=template_path, input_encoding='utf-8')
11
12 report_helper.WebKitHelper.get_mako_template = get_mako_template
13
14=== modified file 'account_financial_report_webkit/report/webkit_parser_header_fix.py'
15--- account_financial_report_webkit/report/webkit_parser_header_fix.py 2014-03-18 14:55:32 +0000
16+++ account_financial_report_webkit/report/webkit_parser_header_fix.py 2014-04-20 00:01:23 +0000
17@@ -38,6 +38,7 @@
18 from openerp.osv.osv import except_osv
19 from openerp.tools.translate import _
20 from openerp import addons
21+from openerp import modules
22 from openerp import pooler
23 from openerp import tools
24 from openerp.addons.report_webkit import webkit_report
25@@ -178,7 +179,7 @@
26 template = False
27
28 if report_xml.report_file:
29- path = addons.get_module_resource(*report_xml.report_file.split(os.path.sep))
30+ path = modules.get_module_resource(*report_xml.report_file.split(os.path.sep))
31 if os.path.exists(path):
32 template = file(path).read()
33 if not template and report_xml.report_webkit_data:

Subscribers

People subscribed via source and target branches

to status/vote changes: