Merge lp:~intellectronica/lazr-js/choiceedit-horizontal-position into lp:lazr-js

[Eleanor Berger]

This branch corrects the placement of the choice edit widget so that it never draws itself in a horizontal position that would cause the page to require horizontal scrolling.

[Michael Nelson (michael.nelson)]

Thanks Tom.

The new code does of course make it possible to put the choicelist off the screen on the left-hand side, but only when the browser width is less than the overlay, so no issue there :)

Thanks!

review: Approve (code/ui)

[Michael Nelson (michael.nelson)]

Actually on second thought, it would be good to actually test for that case, as you *don't* get a scroll bar in that case.

If someone accesses LP on a small screen device they'd not even be able to scroll to see the whole choicelist?

What do you think?

[lp:~intellectronica/lazr-js/choiceedit-horizontal-position]

174. By Eleanor Berger on 2010-03-25

Don't correct the position if the client area is narrower than the widget.

=== modified file 'src-js/lazrjs/choiceedit/choiceedit.js'
--- src-js/lazrjs/choiceedit/choiceedit.js	2010-02-27 16:36:36 +0000
+++ src-js/lazrjs/choiceedit/choiceedit.js	2010-03-25 10:56:31 +0000
@@ -535,6 +535,11 @@
         if (valueX < 0) {
             valueX = 0;
         }
+        if ((valueX > 
+             document.body.clientWidth - boundingBox.get('offsetWidth')) &&
+            (document.body.clientWidth > boundingBox.get('offsetWidth'))) {
+            valueX = document.body.clientWidth - boundingBox.get('offsetWidth');
+        }
         if (valueY < 0) {
             valueY = 0;
         }