Launchpad itself

Merge lp:~intellectronica/launchpad/test-failure-fix into lp:launchpad/db-devel

  1. test-failure-fix
  2. Merge into db-devel
Proposed by Eleanor Berger on 2010-02-17
Status: Merged
Merged at revision: not available
Proposed branch: lp:~intellectronica/launchpad/test-failure-fix
Merge into: lp:launchpad/db-devel
Diff against target: 11 lines (+2/-0)
1 file modified
lib/lp/bugs/doc/bugattachments.txt (+2/-0)
To merge this branch: bzr merge lp:~intellectronica/launchpad/test-failure-fix
Reviewer Review Type Date Requested Status
Deryck Hodge (community) code 2010-02-17 Approve on 2010-02-17
Review via email: mp+19529@code.launchpad.net
To post a comment you must log in.
Eleanor Berger (intellectronica) wrote :

This branch fixes a test that started failing after the implementation of IBug.has_patches changed to rely on a column populated by a trigger. To get the column populated with the correct value, we now commit the transaction and re-fetch the object in the doctest.

Deryck Hodge (deryck) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/bugs/doc/bugattachments.txt'
2--- lib/lp/bugs/doc/bugattachments.txt 2010-01-24 14:31:42 +0000
3+++ lib/lp/bugs/doc/bugattachments.txt 2010-02-17 20:05:27 +0000
4@@ -508,6 +508,8 @@
5 ... is_patch=True)
6 >>> bug_two.attachments.count()
7 2
8+ >>> transaction.commit()
9+ >>> bug_two = getUtility(IBugSet).get(2)
10 >>> bug_two.has_patches
11 True
12

Subscribers

People subscribed via source and target branches

to status/vote changes: