Merge lp:~intellectronica/launchpad/search-for-bugs-affecting-me into lp:launchpad

[Eleanor Berger]

[Eleanor Berger (intellectronica)]

This branch adds a new parameter to bug searches, allowing the user to limit the results to bugs marked as affecting them.

[Deryck Hodge (deryck)]

Looks good to me. As mentioned at the sprint, I think we need something to clarify what you're doing with the reduce statement, just so its easy to scan the test and get what's going on. It wasn't obvious to me on first glance.

Otherwise, well done. Thanks!

Cheers,
deryck

review: Approve (code)

[Jonathan Lange (jml)]

FWIW, I think that the builtin 'all' does exactly what that reduce statement does.

[Eleanor Berger (intellectronica)]

Duh, it does! I'll change that after the rollout.

=== modified file 'lib/lp/bugs/doc/bugtask-search.txt'
--- lib/lp/bugs/doc/bugtask-search.txt	2009-07-01 13:16:44 +0000
+++ lib/lp/bugs/doc/bugtask-search.txt	2010-01-21 17:41:19 +0000
@@ -950,6 +950,21 @@
     >>> ubuntu.searchTasks(search_params).count()
     0
 
+== Searching for bugs affecting me ==
+
+The user searching for bugs can search for bugs affecting him.
+
+We search for bugs affecting foo_bar, then check that all the results
+return True for isUserAffected(foo_bar).
+
+    >>> search_params = BugTaskSearchParams(
+    ...     user=foo_bar, affects_me=True)
+    >>> print reduce(
+    ...     lambda x, y: x and y,
+    ...     [task.bug.isUserAffected(foo_bar)
+    ...      for task in firefox.searchTasks(search_params)]) 
+    True
+
 
 == Ordering search results ==
 

=== modified file 'lib/lp/bugs/interfaces/bugtask.py'
--- lib/lp/bugs/interfaces/bugtask.py	2009-08-25 13:51:39 +0000
+++ lib/lp/bugs/interfaces/bugtask.py	2010-01-21 17:41:19 +0000
@@ -788,6 +788,8 @@
     subscriber = Choice(
         title=_('Bug subscriber'), vocabulary='ValidPersonOrTeam',
         required=False)
+    affects_me = Bool(
+        title=_('Show only bugs affecting me'), required=False)
 
 
 class IBugTaskSearch(IBugTaskSearchBase):
@@ -966,8 +968,8 @@
                  resolved_upstream=False, open_upstream=False,
                  has_no_upstream_bugtask=False, tag=None, has_cve=False,
                  bug_supervisor=None, bug_reporter=None, nominated_for=None,
-                 bug_commenter=None, omit_targeted=False,
-                 date_closed=None, affected_user=None, hardware_bus=None,
+                 bug_commenter=None, omit_targeted=False, date_closed=None,
+                 affected_user=None, affects_me=False, hardware_bus=None,
                  hardware_vendor_id=None, hardware_product_id=None,
                  hardware_driver_name=None, hardware_driver_package_name=None,
                  hardware_owner_is_bug_reporter=None,
@@ -1005,6 +1007,7 @@
         self.bug_commenter = bug_commenter
         self.date_closed = date_closed
         self.affected_user = affected_user
+        self.affects_me = affects_me
         self.hardware_bus = hardware_bus
         self.hardware_vendor_id = hardware_vendor_id
         self.hardware_product_id = hardware_product_id
@@ -1074,7 +1077,8 @@
                        importance=None,
                        assignee=None, bug_reporter=None, bug_supervisor=None,
                        bug_commenter=None, bug_subscriber=None, owner=None,
-                       affected_user=None, has_patch=None, has_cve=None,
+                       affected_user=None, affects_me=False,
+                       has_patch=None, has_cve=None,
                        distribution=None, tags=None,
                        tags_combinator=BugTagsSearchCombinator.ALL,
                        omit_duplicates=True, omit_targeted=None,

=== modified file 'lib/lp/bugs/model/bugtarget.py'
--- lib/lp/bugs/model/bugtarget.py	2009-08-18 11:14:07 +0000
+++ lib/lp/bugs/model/bugtarget.py	2010-01-21 17:41:19 +0000
@@ -44,7 +44,7 @@
                     importance=None,
                     assignee=None, bug_reporter=None, bug_supervisor=None,
                     bug_commenter=None, bug_subscriber=None, owner=None,
-                    affected_user=None,
+                    affected_user=None, affects_me=False,
                     has_patch=None, has_cve=None, distribution=None,
                     tags=None, tags_combinator=BugTagsSearchCombinator.ALL,
                     omit_duplicates=True, omit_targeted=None,

=== modified file 'lib/lp/bugs/model/bugtask.py'
--- lib/lp/bugs/model/bugtask.py	2009-12-15 13:50:22 +0000
+++ lib/lp/bugs/model/bugtask.py	2010-01-21 17:41:19 +0000
@@ -1617,6 +1617,8 @@
             """ % sqlvalues(bug_commenter=params.bug_commenter)
             extra_clauses.append(bug_commenter_clause)
 
+        if params.affects_me:
+            params.affected_user = params.user
         if params.affected_user:
             affected_user_clause = """
             BugTask.id IN (

=== modified file 'lib/lp/bugs/templates/bugtask-macros-tableview.pt'
--- lib/lp/bugs/templates/bugtask-macros-tableview.pt	2009-07-17 17:59:07 +0000
+++ lib/lp/bugs/templates/bugtask-macros-tableview.pt	2010-01-21 17:41:19 +0000
@@ -547,6 +547,16 @@
                   </label>
               </td>
             </tr>
+            <tr>
+	      <td>
+	      </td>
+          <td style="white-space: nowrap">
+            <input tal:replace="structure view/widgets/affects_me" />
+            <label tal:attributes="for view/widgets/affects_me/name">
+                Show only bugs affecting me
+            </label>
+          </td>
+        </tr>
 	    <tr>
               <tal:XXX condition="nothing">
                 # XXX: Bjorn Tillenius 2006-10-02: