Merge lp:~intellectronica/launchpad/hot-bugs-summary into lp:launchpad

Proposed by Eleanor Berger on 2009-09-21
Status: Merged
Approved by: Brad Crittenden on 2009-09-21
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~intellectronica/launchpad/hot-bugs-summary
Merge into: lp:launchpad
Diff against target: None lines
To merge this branch: bzr merge lp:~intellectronica/launchpad/hot-bugs-summary
Reviewer Review Type Date Requested Status
Brad Crittenden (community) release-critical Approve on 2009-09-21
Henning Eggers (community) code 2009-09-21 Approve on 2009-09-21
Review via email: mp+12150@code.launchpad.net
To post a comment you must log in.
Eleanor Berger (intellectronica) wrote :

This branch fixes the field used for the bug summary in the new 'hot bugs' listing on the bugs homepage for a project. It now uses bugtask.bug.title instead of bugtask.title (which is incorrect). I've also added a minimal pagetest which was missing.

Henning Eggers (henninge) wrote :

Good, quick, and easy fix. Thanks for improving test coverage!

Henning

review: Approve (code)
Brad Crittenden (bac) wrote :

Nice work Tom.

review: Approve (release-critical)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/bugs/stories/bugs/xx-product-bugs-page.txt'
2--- lib/lp/bugs/stories/bugs/xx-product-bugs-page.txt 2009-09-20 16:05:43 +0000
3+++ lib/lp/bugs/stories/bugs/xx-product-bugs-page.txt 2009-09-21 08:58:50 +0000
4@@ -160,3 +160,19 @@
5 >>> print_bugtasks(anon_browser.contents)
6 5 Firefox install instructions should be complete
7 Critical New
8+
9+
10+== Hot Bugs ==
11+
12+A listing of the 10 'hottest' bugs (currently simply the bugs most recently
13+touched) is display to allow a quick overview of the project. For each bug we
14+have the number, title, status, importance and the time since the last update.
15+
16+ >>> anon_browser.open('http://bugs.launchpad.dev/firefox')
17+ >>> print extract_text(
18+ ... find_tag_by_id(anon_browser.contents, 'hot-bugs'))
19+ Summary Status Importance Last changed
20+ #14 Firefox install... New Critical on 2006-07-14
21+ #13 Reflow problems... New Medium on 2006-07-14
22+ #2 Firefox does no... New Low on 2006-05-19
23+
24
25=== modified file 'lib/lp/bugs/templates/bugtarget-bugs.pt'
26--- lib/lp/bugs/templates/bugtarget-bugs.pt 2009-09-20 16:05:43 +0000
27+++ lib/lp/bugs/templates/bugtarget-bugs.pt 2009-09-21 08:58:50 +0000
28@@ -202,7 +202,7 @@
29 </td>
30 <td>
31 <a tal:attributes="href bugtask/fmt:url"
32- tal:content="bugtask/title" />
33+ tal:content="bugtask/bug/title" />
34 </td>
35 <td tal:attributes="class string:status${bugtask/status/name}"
36 tal:content="bugtask/status/title" />