Code review comment for lp:~inspirated/launchpad/implement-Bug-findAttachments

Revision history for this message
Robert Collins (lifeless) wrote :

Scanning even a single MB of content in a webserver request is going to have serious consequences on our capacity and performance (due to python and the GIL amongst other things).

We should broadly provide two things:
 - index the attachments where we can do so. We may need search overhauled - please feed your SoC stories into https://dev.launchpad.net/LEP/Search - thanks
 - events for new attachments so that someone wanting to can write an external custom indexer for such things.

This branch doesn't do either of these - sorry, but I really can't accept it into the code base.

Please speak with me or Graham (or anyone on the Bugs or Foundations teams) to move forward with your project - it sounds cool and I want to see it happen.

review: Abstain

« Back to merge proposal