Code review comment for lp:~inkscape+alexander/inkscape/offset-cubic-improvement
Revision history for this message
| Alexander Brock (brock-alexander) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
357f4db
(Get the code!)
I made the tolerance a parameter of outline and half_outline. If not set (or set to some value <= 0) it is automatically calculated as 5% of the width parameter.
Default tolerance is 5% on my machine and runtime is 6 times slower than the old code in my benchmarks but it's not noticable on my machine in a debug build in the gui.
It creates a smaller number of segments than the old code and the accuracy is much better for small values of width, therefore I propose it for merging.