Code review comment for lp:~inkscape+alexander/inkscape/offset-cubic-improvement

Revision history for this message
Alexander Brock (brock-alexander) wrote :

I added experimental code to ignore degenerate curves, but that changed nothing.

I found the place in the code where the "L 0 0 z" is created:

http://bazaar.launchpad.net/~inkscape+alexander/inkscape/offset-cubic-improvement/view/head:/src/helper/geom-pathstroke.cpp#L1116

content of temp:
M 15.835720153852229 8.14728407690592 C 15.835735083689977 8.14729920020721 15.835750013370388 8.147314323706892 15.835764942893457 8.147329447404967

content of temp2:
M 15.835674601501454 8.147237813173517 L 15.835720153852229 8.14728407690592

Tangents: (-0.7025234740496769, -0.7116605710654292), (0.7016071317351655, 0.7125639849854567)

content of temp after the call to outline_join:

M 15.835720153852229 8.14728407690592 C 15.835735083689977 8.14729920020721 15.835750013370388 8.147314323706892 15.835764942893457 8.147329447404967 L 0 0

I tried to figure out what exactly is happening in outline_join and now my head hurts. Since the problem has nothing to do with the offset_cubic improvements, can we merge this?

« Back to merge proposal